Move vector_random() to free_module.py with doctests #40344
+18
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 30, 2025 12:16
Adds vector_random() as a wrapper for FreeModule(...).random_element(), mirroring matrix.random() for API symmetry. Includes a basic test.
|
Small note: The earlier commit mentions a test file, but that was just temporary while checking behavior. The final PR only includes doctests inside vector_random(), as discussed — no standalone test file added. |
whoami730
suggested changes
Jul 1, 2025
There was a problem hiding this comment.
- As I said earlier, please reduce or avoid AI slop. It looks like everything including code, commit/PR message etc are AI generated. If you wish to do that, please do a self review of your own PR before proceeding to ask for review.
- Fix PR title and avoid raising new PRs for each change, this loses history.
- We already have
random_vectorfunction. Having anothervector_randomfunction is redundant. What is instead needed to have is avector.randommethod akin tomatrix.randommethod. Consider looking at the implementation of the same. - Both
random_vectorandvector.randomshould ideally share implementation as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the vector_random(R, n, *args, **kwargs) function to src/sage/modules/free_module.py.
Mirrors matrix.random() for API consistency
Calls FreeModule(R, n).random_element(...) internally
Adds doctests demonstrating usage with ZZ, QQ, and GF(7)
This avoids modifying core files and addresses the enhancement proposed in #40316.
Let me know if anything should be changed!