Add vector_random.py to support vector.random (#40316) #40319
Conversation
Adds a helper function `vector_random(R, n, *args, **kwargs)` in a new file `src/sage/modules/vector_random.py`. This mirrors `matrix.random()` for API consistency and calls `FreeModule(R, n).random_element(...)` internally. This change avoids modifying core files directly and supports the enhancement in issue sagemath#40316.
|
Hi, I opened PR #40319 to support vector.random() as discussed. It avoids core edits and mirrors matrix.random(). |
There was a problem hiding this comment.
@eslteacher902010 Few comments:
- First and foremost, please avoid or reduce AI slop.
- https://www.freecodecamp.org/news/how-to-write-better-git-commit-messages/
- Be concise
- Documentation and tests should be added.
- New file is not required for only one function, better yet, if you want to make a new file, move other vector related methods to it as well.
Hey, and thanks for the feedback! I've moved vector_random() into free_module.py as suggested and removed the standalone file. |
|
No changes made... |
|
Whoops — I didn’t realize those changes hadn’t been pushed! I’ve NOW moved vector_random() into free_module.py, removed the standalone file, and added doctests with ZZ, QQ, and GF(7) examples. The updated version is in PR #40344. Thanks again and please let me know. |
Adds a helper function
vector_random(R, n, *args, **kwargs)in a new filesrc/sage/modules/vector_random.py.This mirrors
matrix.random()for API consistency and callsFreeModule(R, n).random_element(...)internally.This change avoids modifying core files directly and supports the enhancement in issue #40316.