-
-
Notifications
You must be signed in to change notification settings - Fork 631
Hyperbolic Coxeter type classification added #40343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SamyMekkati
wants to merge
11
commits into
sagemath:develop
Choose a base branch
from
SamyMekkati:develop
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+756
−2
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
b1a8bec
Adding hyperbolic coxeter type classification into sage
SamyMekkati de362ec
is_hyperbolic() defined in coxeter_type
SamyMekkati f53bb1d
Added the hyperbolic type in the samples and added the parameter hype…
SamyMekkati 9d73a4d
Added __eq__ to unbug TestSuite for hyperbolic type
SamyMekkati 6edde1a
fixed docstring
SamyMekkati 2b51e84
add type_hyperbolic in meson.build
SamyMekkati 936cbc3
lint error fixed
SamyMekkati 1cde3ec
lint error fixed pt2
SamyMekkati b01ffce
lint error fixed pt3
SamyMekkati 744a1e2
few docstrings changes
SamyMekkati c28a8e6
few docstrings changes pt2
SamyMekkati File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to add a pair of parentheses around the OR clause