Hyperbolic Coxeter type classification added #40343
Conversation
| @@ -51,6 +52,9 @@ def __classcall_private__(cls, *x): | |||
|
|
|||
| if isinstance(x, CoxeterType): | |||
| return x | |||
|
|
|||
| if isinstance(x,list) and x[0] == "Hyp" or x[0] == "Hyperbolic": | |||
There was a problem hiding this comment.
add one space after comma and before "list"
| @@ -185,8 +193,13 @@ def _samples(self): | |||
| ['C', 5, 1], ['D', 5, 1], ['E', 6, 1], | |||
| ['E', 7, 1], ['E', 8, 1], ['F', 4, 1], | |||
| ['G', 2, 1], ['A', 1, 1]]] | |||
|
|
|||
| hyperbolic = [CoxeterType(t) for t in [['Hyp', (141, 1, 3)], ['Hyp', (141, 1, 4)], | |||
| ['Hyp', (141, 2, 5)], ['Hyp', (142, 1, 6)], | |||
| sage: CoxeterType(['Hyp', (141, 1, 3)]).is_hyperbolic() | ||
| True | ||
| """ | ||
|
|
| from sage.combinat.root_system.coxeter_type import CoxeterType | ||
|
|
||
| """ | ||
| Hyperbolic Coxeter matrices for hyperbolic Coxeter types. |
There was a problem hiding this comment.
no indentation ; one empty line after first line
| """ | ||
| hyperbolic_coxeter_matrices = { | ||
| (141, 1, 1): CoxeterMatrix([ | ||
| [1,4,2,2], |
There was a problem hiding this comment.
spaces after commas, everywhere in this file
|
|
||
| return self._position | ||
|
|
||
|
|
There was a problem hiding this comment.
just one empty line between methods inside a class
| def is_hyperbolic(self): | ||
| """ | ||
| Return ``True`` since ``self`` is a hyperbolic Coxeter type. | ||
| """ |
| sage: C = CoxeterType(["Hyp",(143, 1, 6)]) | ||
| sage: C.index_set() | ||
| (1, 2, 3, 4, 5, 6) | ||
|
|
There was a problem hiding this comment.
no empty line at the end of docs
|
|
||
| def is_affine(self): | ||
| """ | ||
| Return ``False`` since all hyperbolic coxeter graph is not affine. |
There was a problem hiding this comment.
wrong grammar, mix of singular and plural; same in the next method
| def is_crystallographic(self): | ||
| """ | ||
| Return whether ``self`` is crystallographic. | ||
|
|
There was a problem hiding this comment.
just on empty line here, please
|
Documentation preview for this PR (built with commit 9d73a4d; changes) is ready! 🎉 |
|
you also need to add the newly added file to the list in the file meson.build in the same folder |
|
Hi Frédéric, I asked Samy to add this classification as a starter ticket. I wanted to tag you, but you were faster than me! Then, the plan would be to add a recognition function for these. It might be quite involved, but I think it would be great... |
|
Salut Jean-Philippe. Fait trop chaud, alors j'essaye de faire des choses pas trop compliquées.. Si tu as une seconde, peux-tu regarder jplab/brocoli#6 |
|
another question : how does this relate to the tables in McMullen's article : https://www.numdam.org/item/PMIHES_2002__95__151_0.pdf ? |
fchapoton
changed the title
This pull request introduces a classification of Coxeter matrices based on the hyperbolic examples provided in Humphreys' book Reflection Groups and Coxeter Groups (Chapter 6, Appendix, e.g., page 142). The aim is to integrate these specific examples into SageMath as a new Coxeter type by adding the class "CoxeterType_Hyperbolic" and some functions defined in type_hyperbolic.py
📝 Checklist
⌛ Dependencies