-
Notifications
You must be signed in to change notification settings - Fork 154
Feat/update gps tutorial #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: rolling
Are you sure you want to change the base?
Feat/update gps tutorial #115
Conversation
56eb0f0
to
3d4bd8c
Compare
Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com>
Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com>
e524eb9
to
ff96702
Compare
Thank you for making this. I was just trying to run this tutorial and failing and jazzy just doesn't want to work with gazebo classic at all. However, I'm not able to launch it because it seems to be referencing a turtlebot3_waffle_gps.urdf that does not exist in the nav2_minimal_tb3_sim package (at least as currently released). I can make some guesses about what to go change in that package but as-is, this is either dependent on an upstream library change or maybe need to pull that modified turtlebot into this repo? Edit: Oh, I see you mention the related library package change in the parent issue #114 - I'll test it out. |
It should be there because nav2 used it to run some tests.
I made some changes, use my branch, below
Now all urdf are in the nav2_min_sim repo |
I've installed both of your branches, and gz launches ok, but I just get a blank screen. I can launch other simulations just fine, so the system is generally working. I don't see any hard Error messages in my logs that suggest what is failing in this launch, and I get the ros topics publishing as expected. I do receive a number of warnings though:
I'm not 100% sure if that's enough to be a fatal error in spawning the gazebo world, and suspect it's related to the changes over here: I will keep poking around and update if I have something more informative to say (I'm quite a noob on gazebo anything and don't have a great feel for the error messages). And again, thank you for contributing this. |
Someone else also mentioned this to me too about the blank screen. I am not able to reproduce it. What environment are you using, I am currently using the nav2 docker, where I build all the other repo in it, I can share my .dev container for vs code if you are familiar with vs code dev container. |
This is where it is installed in the docker container |
I think found the issue. This line: 64fce3b#diff-2302c3058efb8f702a32ded1a29b2f16814c1ddcf50a9313561540fe0955ab44R96 Seems to reference casing that is not consistent on my machine (ubuntu). I still haven't gotten it to come up cleanly yet but I think that was the main blocker. |
And yes I'm running in docker and would very much appreciate the devcontainer to try to repro |
I am not t home ATM, but Actually I am using the same dev container as in navigation2, uncomment all options to allow visualization in the dev container. I mounted the sim and tutorial repo to the underlay_ws and built there |
What line exactly, this is a commit that includes multiple changes |
Sorry the line in question is highlighted at the bottom (but didn't actually zoom there). I think (thought?) it had to do with the casing in that line, but am still not there. |
I still don't get the line you are referring too. Can you send a screenshot. |
Did you source your environment after the build? Might sound silly just to confirm. |
Also I tested mine with the rolling docker |
I think the problem is related to this block:
At least for what I'm experiencing. If I xacro the world.sdf file, and try to launch it with just I'm working on a super clean repro in the nav2 dev container because I was working from within my project's dev container, which may be dirty or something. (I'm using Jazzy for the record) |
The Sonora model is in the repo actually. This is where it is called from the launch file. Which launch file are you using? |
|
This is how I launch it btw. I'm certain I've got the sourcing happening. Still waiting on the nav2 dev container to finish building (30 minutes in at this point) |
It did launch fine in the rolling dev container. |
Can you try the same in jazzy, to see if it works? |
I may give bringing it up in Jazzy a shot later in the day. Another thing to mention is that Bing Maps API Key (as referenced in the docs) is totally deprecated (swri-robotics/mapviz#851), so i'm not sure the best path forward there (and the mapviz folks don't seem to have a hyper clear answer either) =/ |
In the pr of nav2.orgs I explained the use of stadia maps with their API. There is also even an option to have maps locally. Please read my branch of the nav2.orgs😅 not the explanation currently on the nav2 website. I removed the bing option because indeed it is deprecated. |
|
I tried it in jazzy and it shows a blank screen, here are the log files |
@Heet06 Please to make sure that it is not your environment can you try what @litch did. git clone -b feat/update_gps_tutorial https://github.com/stevedanomodolor/navigation2_tutorials.git cd nav2_minimal_turtlebot_simulation cd ../navigation2_tutorials ros2 launch nav2_gps_waypoint_follower_demo gazebo_gps_world.launch.py also build the latest nav2 branch too. |
Ok. I was working from your repo and put my stadiamaps api key (which was a UUID) and just got a continuous screaming about "NETWORK ERROR: Host requires authentication" and I thought it may be because of the bing api key being blank but it seems I had just pasted my stadiamaps API key wrongly. Sorry for false alarm. =) I also found in the docs you have the params for the keyboard to emit stamped correctly. Thank you. The nav2 dev container didn't seem to have rviz2 in it, so I had to add rviz2 for the final step to work, but yeah I got the whole stack up and running. Phew! That was a lot of work but it's very cool =) |
About the rviz2 thing, I have always wondered why it was not in the docker file by default, always installed it. @SteveMacenski thoughts |
I think the issue is with Gazebo environment variable that needs to be set for gazebo which in docker container is already done, it should be something like this: |
Another thing is use sdf for world it works! |
Happy to hear you got it running on Jazzy. 🎉🎉🎉 we indeed set the variable in the launch file. With respect to the SDF file format, .SDF.xacro shouldnt be a problem either. I guess it depends how you set it from your launch file. In the case you are creating a custom launch file I would recommend you see the following example; |
My simulation is working and keyboard teleop also works but waffle doesn't move when using nav2 any suggestions if someone knows why and how this happened and I am using all the same things from the repository. |
Can you send me a video or something to understand what you mean? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Broadly approved (assuming the other users can get it to work)! Should this be backported into any of the other branches?
@@ -196,10 +195,11 @@ local_costmap: | |||
raytrace_min_range: 0.0 | |||
obstacle_max_range: 2.5 | |||
obstacle_min_range: 0.0 | |||
static_layer: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is used in the configuration
|
||
# GPS WPF CHANGE: Remove static layer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you leave these comments in?
always_send_full_costmap: True | ||
|
||
# GPS WPF CHANGE: Remove static layer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto
@@ -247,19 +249,48 @@ global_costmap: | |||
# ros__parameters: | |||
# yaml_filename: "" | |||
|
|||
keepout_filter_mask_server: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can these be removed since they're not used in this demo? This and the new things below
Most likely it should, especially for jazzy. @Heet06 mentioned he had an issue with jazzy, not sure if it is special configuration he has on his side or the same as the tutorial. I will test this on the jazzy branch to see if any problem arises. |
No description provided.