-
Notifications
You must be signed in to change notification settings - Fork 4
WIP: DEMO branch with css fixes #298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
SaqAsh
wants to merge
250
commits into
main
Choose a base branch
from
feature/demo
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+491
−475
Draft
Changes from all commits
Commits
Show all changes
250 commits
Select commit
Hold shift + click to select a range
5b09c2e
finish up code cleanup and make sure that all styling is close to fig…
SaqAsh 0fa14d9
type theme appropriately instead of settling for any
SaqAsh 62b5ec4
fix styling and add comments for fonts
SaqAsh 376f887
add some permuations of testing and reduce the threshold constants
SaqAsh afe4e16
final cleanup before pr, remove uneccesary styling
SaqAsh 8e7cc5e
fix logic flaw
SaqAsh 296af83
add minor spacing
SaqAsh b123752
remove tacky v
SaqAsh 532260f
port over the button implementation from stage into here in order to …
SaqAsh 28a164f
fix minor css styling
SaqAsh 8d86be9
add more configuations to the story
SaqAsh ed90b72
finish adding all neccasry components for expansion and collapseable …
SaqAsh cc05e97
fix horizontal scrolling issue with css
SaqAsh c0b3dc4
initialize the table of contents component
SaqAsh 8d9f78d
handle logic for the actual scrolling into view for scheams
SaqAsh ee3a2c9
clean up the table of contents, add the relevant functions
SaqAsh 9f2bd1d
cleanup css styling such that it is uniform and has no unessesary att…
SaqAsh 5414669
fix subpar styling for dropdown
SaqAsh c10619c
code cleanup
SaqAsh ffa06e0
add an advanced.json to better facilitate visualation of table of con…
SaqAsh 3f5549e
port over the attribute filter from stage
SaqAsh ce91494
fix naming issue with list
SaqAsh 6c065a5
Merge branch 'feature/Table-of-contents' into feature/attribute-filte…
SaqAsh 6a68b7a
finish up attribute filter dropdown implementation
SaqAsh eab689f
relocate all interaction panel based things in a different folder for…
SaqAsh edc0902
moving dropdown into the interaction panel
SaqAsh 2b1c714
initial commit, initializing the component
SaqAsh 41baefa
use theme context instead of individually importing the icon
SaqAsh 24aeabd
complete implementation of the dictionary download button
SaqAsh 7011532
make the download template button actually interactive
SaqAsh 1268d0b
Merge branch 'feature/download-templates' into feature/attribute-filt…
SaqAsh 109773c
reoganize the components all together as one interaction panel story
SaqAsh 0c97a59
finalizing the styling according to the figma
SaqAsh 54d0243
fix styling for buttons
SaqAsh 14fbcb6
Merge branch 'feature/expand-collapse-all-button' into feature/attrib…
SaqAsh 5b7656c
Merge branch 'feature/Table-of-contents' into feature/attribute-filte…
SaqAsh 5598d09
dictionary version implementation finished
SaqAsh 84b5619
initialize the interaction component
SaqAsh f58ec3f
interaction bar rearrangement and left and right row addition
SaqAsh 449782f
Merge branch 'main' into feature/dictionary-version-switcher
SaqAsh f4ccb29
make updates to the package.json to make the lectern client available
SaqAsh 97a4f61
implement disasbled state for dropdown
SaqAsh fc4cee3
add a disasbled state as part of the demo for the dropdown, going to …
SaqAsh ccaf112
implement disabled state for interaction panel
SaqAsh ae26b10
interaction panel implement disasbled state in stories
SaqAsh 00cf2fa
add testing for the version switcher
SaqAsh bc3f058
merge from the version switcher
SaqAsh 5b1768e
Merge branch 'feature/header-component' into feature/interaction-panel
SaqAsh 9280d6a
Added some different cases for the interaction panel
SaqAsh 3d598de
add licencing
SaqAsh 89ed33f
initial component initialization
SaqAsh 30f6bee
allow the ability to actually initalize the openInit
SaqAsh 694931f
add line seperation, fix up styling
SaqAsh dc2949b
make it so that we have appropriate aligning
SaqAsh 69c2ec6
address preceeding text spacing comment from pr
SaqAsh 174922f
exporting component props
SaqAsh 60dab2d
rename the constant to fit the naming standards better and add commen…
SaqAsh d372d65
Merge branch 'feature/header-component' into feature/accordian-cards
SaqAsh 6bfcc69
move the state management inside of the accordion, pt1
SaqAsh 322c21d
whitespace
SaqAsh 0d98f89
hover state
SaqAsh 8601b5a
export all props
SaqAsh 36e5af9
defaulted spinner width height and fill values
SaqAsh d0f4631
change console.log to alerts
SaqAsh 9605e9f
do not control state of other components, addresses pr feedback
SaqAsh c1f2083
Merge branch 'feature/expand-collapse-all-button' into feature/accord…
SaqAsh 634107b
add back disasbled state from interaction panel
SaqAsh 659a456
generated dictionarypage for now just to see everything working at on…
SaqAsh 50a8e5c
Merge branch 'main' into feature/Table-of-contents
SaqAsh fe1dd0e
move advanced.json and fix import
SaqAsh 9f29bf9
we want user inputted styles to be in highest priority
SaqAsh 35556bb
export props
SaqAsh 902eccc
change from console.log to alert
SaqAsh b0b0dab
instead of increasing the border width, add a box shadow instead
SaqAsh 4b42736
make hover state less prominent
SaqAsh 140eaf6
add a new button variant, iconOnly
SaqAsh 229928f
styling buttons such that we have the ability to pass in custom style…
SaqAsh 6bb1355
add the hash
SaqAsh 9b344ed
fix some div hierarchy issues with the spans not properly being stack…
SaqAsh 7de835c
remove errors from stories, need to consider the case for a longer ti…
SaqAsh 7516587
attempt 1 of getting the title to wrap when too big
SaqAsh 1997c6c
implement handling of a long title
SaqAsh 316750b
refactor the read-more/read-less logic
SaqAsh 7744643
make the transition smooth with css without the use of useEffect
SaqAsh 50503e6
clean up css finally
SaqAsh b2bc3eb
whitespace fix
SaqAsh 2da8a34
general copying pattern
SaqAsh 0c6f710
finalize the url hash navigation
SaqAsh 5973dd4
rework the table of contents dropdown stuff, and chat gpt the diction…
SaqAsh 7db7058
implement pr review changes
SaqAsh 69467f0
add a todo for the buttons rendering
SaqAsh 34445e9
accidentally removed export
SaqAsh e9a068e
fix naming inside of stories to make it consistent with props
SaqAsh 5f48538
table of contents merge
SaqAsh 03cfa52
collapse button merge
SaqAsh 639334a
move filter dropdown from stage to lectern
SaqAsh 2e3153b
port over attribute filter dropdown from stage
SaqAsh e9b0eaf
fix states in the interaction panel component
SaqAsh b82cd39
remove all the extra props that weren't needed
SaqAsh 36419fb
fix the panel with the new props
SaqAsh e7a0b17
fix errors due to the new dictionary config
SaqAsh 9bd6322
add disasbled state
SaqAsh d337d8e
fix filter label
SaqAsh 1cfdc68
Merge branch 'main' into feature/interaction-panel
SaqAsh 344da2b
file download pattern following
SaqAsh 9133031
make the stories more case handling
SaqAsh 1de4f70
make the icon filedownload follow the common pattern
SaqAsh a7e293f
fix the icons
SaqAsh d8478ad
download templates pr review comments
SaqAsh 2e8400a
Merge branch 'main' into feature/Table-of-contents
SaqAsh 96ff5e5
Merge branch 'main' into feature/expand-collapse-all-button
SaqAsh 0f1f851
Merge branch 'main' into feature/header-component
SaqAsh a7edf37
Merge branch 'feature/interaction-panel' into feature/accordian-cards
SaqAsh 06fe036
data dictionary page was a mess and not needed currently
SaqAsh 4c474e3
the individual schema does not need the description or name
SaqAsh e58ee03
Remove max width from the table and make sure that the table is refac…
SaqAsh 0115324
fix up the table columns, schemaField Html is useless now
SaqAsh 42a6d1e
add back the field's description name after accidental removal
SaqAsh 8bc0b79
fix css
SaqAsh 8b13278
fix the rendering of the descriptions
SaqAsh 480a313
render examples fields if available inside of the meta
SaqAsh e4d542f
render examples
SaqAsh 5e528f8
clean up the handling for the hash
SaqAsh 3f61b33
add the filter dropdown from stage
SaqAsh a02c93b
finishing up code clean-up
SaqAsh 600f63f
clean up code to meet standards better
SaqAsh a6c9d47
clean up the stories and spread through the mockedproperties
SaqAsh 9d6a0cb
some slob generated to get some scroll behaviour working
SaqAsh ab90868
fix the fileType
SaqAsh 353e806
fixed code readibility, abstracted things into functions
SaqAsh 94d3338
remove over engineering
SaqAsh 9879efb
abstract download button out of the component, shouldn't be needing t…
SaqAsh bd627d7
Merge branch 'feature/interaction-panel' into feature/accordian-cards
SaqAsh 4565336
fix error
SaqAsh 1bf7e66
make sure that there is no sharing of the types.
SaqAsh 6a5a487
fix cross referencing issues
SaqAsh e1de3f8
Merge branch 'feature/interaction-panel' into feature/accordian-cards
SaqAsh f9568ce
Merge branch 'feature/header-component' into feature/interaction-panel
SaqAsh 92b43c9
useable state for the table scrolling
SaqAsh 5ccf451
commit
SaqAsh d564435
testing
SaqAsh 4a66afb
Merge remote-tracking branch 'origin/feature/schema-table-a' into fea…
SaqAsh 6a23c4f
FIX VITE CONFIG ISSUES
SaqAsh 8876368
slight refactor
SaqAsh 24cc1a4
Allowed Values working... kinda
SaqAsh 8059255
got a googled pill component, and pasted it in
SaqAsh 7ace926
pill implementation complete
SaqAsh 830cf33
capitalize the first letter since that is required in the figma
SaqAsh e032f3b
conditional restrictions schema table part c done
SaqAsh 9792fa5
delimted requirement finish
SaqAsh af66e7e
add sticky header
SaqAsh 93cbadb
slight refactor
SaqAsh 69e6907
schema a b and the other tickets almost done
SaqAsh f221ab7
implement the modal button
SaqAsh 97b3b5e
some fonting changes
SaqAsh d0394c0
handle primary key
SaqAsh 3e0eeda
appropriately type examples
SaqAsh 8b69c4f
add borders
SaqAsh 8ae8b69
remove set timeout used for debugging purposes
SaqAsh 92fce9e
remove classname
SaqAsh b7f3225
address pr feedback
SaqAsh acce16f
address pr feedback
SaqAsh dc36553
append quotes onto the words
SaqAsh 7c40856
some css changes
SaqAsh c54ec9a
more bolding
SaqAsh c12142b
fix some logical issues as well as some css
SaqAsh bae83b1
css changes for the table
SaqAsh 85216b2
code style fixes
SaqAsh 19e4079
Merge branch 'feature/Table-of-contents' into feature/interaction-panel
SaqAsh 0feb97b
Merge branch 'feature/expand-collapse-all-button' into feature/intera…
SaqAsh cd9ede9
Merge branch 'feature/header-component' into feature/interaction-panel
SaqAsh b39af9b
remove the side effects inside of the TableOfContentsDropdown
SaqAsh e9fd874
Merge branch 'main' into feature/interaction-panel
SaqAsh f76e907
naming consistency fixes and fix any css
SaqAsh d0db70d
revert some cleanup since its messed up some stuff
SaqAsh 63d5c30
Merge branch 'feature/interaction-panel' into feature/accordian-cards
SaqAsh a2f69bb
remove the bug accidentally introduced
SaqAsh 9cb7474
Merge branch 'feature/accordion-cards' into feature/schema-table
SaqAsh 9430030
seperate the return type into prefix and content to easily render
SaqAsh c06e62b
add the bolding for the prefixes
SaqAsh 36bd606
fix the required when styling
SaqAsh 91ac153
remove hello world className
SaqAsh 487be50
add new lines
SaqAsh 1dff495
some naming changes and getting rid of pill dark mode
SaqAsh 9606a27
fix the allowed values
SaqAsh 67f084b
Merge branch 'main' into feature/accordion-cards
SaqAsh 85c3a76
remove comments and add licencing and export type
SaqAsh 14304b3
remove useless comments
SaqAsh cacce41
cleanup types and html semantics
SaqAsh f4c5813
some functional changes
SaqAsh d1ac0c1
further code cleanup
SaqAsh c5d99d2
accidental file change fix
SaqAsh 8ee7415
accidental file change fix
SaqAsh 667f366
format import for pr
SaqAsh f735547
Merge branch 'feature/accordion-cards' into feature/schema-table
SaqAsh 14e5770
undo to reduce number of files reviewed
SaqAsh 7e6a70d
reduce diff with removing uneccessary code changes
SaqAsh 92fd010
add line breaks and fix up formatting if needed
SaqAsh e3c3eee
clean up the header component with the use of the readmore
SaqAsh 0729747
generated demo page.
SaqAsh 59cdf22
table width fix
SaqAsh 23d7820
cleanup imports
SaqAsh d2ed3f1
fix overlaying css issue
SaqAsh faa4ba5
fix vertical alignment
SaqAsh e111d4c
add mock data
SaqAsh 2cd1202
add version switching
SaqAsh ee63fc3
Update packages/ui/src/common/ReadMoreText.tsx
SaqAsh eb12646
fix typo as well as fix the import spacing
SaqAsh 2ef89ff
move copying logic into a seperate hook
SaqAsh f4280ba
make whole area clickable
SaqAsh a42aeae
fix html type
SaqAsh c939f27
suggestion for the download dictionary buttont to be cleanedup interally
SaqAsh 79ae687
remove children dependency, content isn't dynamic once the page is lo…
SaqAsh 3484c90
Merge branch 'feature/accordion-cards' into feature/demo
SaqAsh 5f78729
comments
SaqAsh 97d7790
reduce the use of prop via exporting the hook
SaqAsh a28df45
use ref instead of getElementById
SaqAsh a1f0027
slight refactor with the props
SaqAsh 553daec
add comment for why we have mock props
SaqAsh 6fb2b31
fix the semantic html issues
SaqAsh 3e5dfee
finish fixing up css
SaqAsh 13f32d7
fix any other redundant css and move comment
SaqAsh a75f9be
Merge branch 'feature/accordion-cards' into feature/demo
SaqAsh e6af220
fix dropdown css
SaqAsh 5dc9b75
make the header sticky
SaqAsh c9f20b5
remove uneccessary styling and like z-index
SaqAsh 83a503d
fix filtering logic
SaqAsh ba7057e
fix up a lot of the logic and make it such that we actually have pro…
SaqAsh c1879bb
remove all redundant css
SaqAsh 22f4994
fix html semantic issues
SaqAsh d20b93e
fix some accessibility
SaqAsh 724d6bd
nuked old typography inside of theme and nuked styles folder that was…
SaqAsh 5c03dd8
refactored pill component with the new fonting
SaqAsh 71a9af3
finish refactoring the dictionary header with appropriate fonts
SaqAsh 1f4aae6
fix the linter issue with the allowed values columns
SaqAsh 14281db
fix the read more text with the errors in fonting
SaqAsh 823df17
fix the table header and fields fonting
SaqAsh 56fa752
fix the typing slightly
SaqAsh 9da52f7
fix the accordion hash navigation scrolling bug, and fix typography i…
SaqAsh a59ac2e
undo typing fix, broke the value
SaqAsh 0a547ea
fix the hash navigation scrolling issue, however the hash navigation …
SaqAsh f56da24
fix the icons
SaqAsh 620bc24
fix the scroll into view
SaqAsh 8823df1
full width to pill
SaqAsh 50b0407
Merge branch 'main' into feature/demo
SaqAsh 497a399
merge fixes, branch now building
SaqAsh 858b3be
port over the pill from main
SaqAsh 9ff7aaa
remove allowed values column
SaqAsh 015f2cc
reduce diff...
SaqAsh a94efd2
accessiblity fixes
SaqAsh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -47,11 +47,11 @@ const accordionItemStyle = (theme: Theme) => css` | |
overflow: hidden; | ||
background-color: #ffffff; | ||
box-shadow: | ||
0 2px 6px rgba(70, 63, 63, 0.05), | ||
0 2px 6px rgba(70, 63, 63, 0.3), | ||
0 0 0 0.3px ${theme.colors.black}; | ||
&:hover { | ||
box-shadow: | ||
0 2px 6px rgba(70, 63, 63, 0.15), | ||
0 2px 6px rgba(70, 63, 63, 0.5), | ||
0 0 0 0.3px ${theme.colors.black}; | ||
} | ||
transition: all 0.3s ease; | ||
|
@@ -71,34 +71,35 @@ const accordionItemButtonStyle = (theme: Theme) => css` | |
display: flex; | ||
border: none; | ||
align-items: center; | ||
color: ${theme.colors.accent_dark}; | ||
cursor: pointer; | ||
${theme.typography?.button}; | ||
text-align: left; | ||
background: transparent; | ||
padding: 8px 0; | ||
flex: 1; | ||
padding: 8px 0px; | ||
`; | ||
const titleStyle = (theme: Theme) => css` | ||
${theme.typography?.subtitleSecondary}; | ||
color: ${theme.colors.accent_dark}; | ||
text-align: left; | ||
`; | ||
|
||
const chevronStyle = (isOpen: boolean) => css` | ||
transform: ${isOpen ? 'rotate(0deg)' : 'rotate(-90deg)'}; | ||
transition: transform 0.2s ease; | ||
margin-right: 12px; | ||
flex-shrink: 0; | ||
`; | ||
|
||
const contentContainerStyle = css` | ||
display: flex; | ||
flex-direction: column; | ||
align-items: flex-start; | ||
flex: 1; | ||
`; | ||
|
||
const titleRowStyle = css` | ||
display: flex; | ||
gap: 2px; | ||
align-items: center; | ||
width: 100%; | ||
margin-bottom: 10px; | ||
flex-direction: auto; | ||
flex-wrap: wrap; | ||
`; | ||
|
||
const hashIconStyle = (theme: Theme) => css` | ||
|
@@ -107,27 +108,19 @@ const hashIconStyle = (theme: Theme) => css` | |
background: transparent; | ||
border: none; | ||
cursor: pointer; | ||
padding: 0; | ||
|
||
svg { | ||
border-bottom: 2px solid ${theme.colors.secondary}; | ||
} | ||
|
||
&:hover { | ||
opacity: 1; | ||
} | ||
`; | ||
|
||
const descriptionWrapperStyle = (theme: Theme) => css` | ||
${theme.typography?.label2}; | ||
color: ${theme.colors.grey_5}; | ||
${theme.typography.paragraphSmall}; | ||
color: ${theme.colors.black}; | ||
overflow-wrap: break-word; | ||
width: 100%; | ||
`; | ||
|
||
const downloadButtonContainerStyle = css` | ||
flex-shrink: 0; | ||
margin-right: 8px; | ||
margin-left: 16px; | ||
`; | ||
|
||
const accordionCollapseStyle = (isOpen: boolean) => css` | ||
|
@@ -137,7 +130,7 @@ const accordionCollapseStyle = (isOpen: boolean) => css` | |
`; | ||
|
||
const accordionItemContentStyle = css` | ||
padding: 30px; | ||
padding: 0px 30px 30px 30px; | ||
`; | ||
|
||
const contentInnerContainerStyle = (theme: Theme) => css` | ||
|
@@ -148,16 +141,15 @@ const contentInnerContainerStyle = (theme: Theme) => css` | |
|
||
const handleInitialHashCheck = ( | ||
windowLocationHash: string, | ||
accordionData: AccordionData, | ||
openState: AccordionOpenState, | ||
indexString: string, | ||
accordionRef: RefObject<HTMLLIElement | null>, | ||
) => { | ||
if (window.location.hash === windowLocationHash) { | ||
if (!accordionData.openOnInit) { | ||
openState.toggle(); | ||
} | ||
accordionRef.current?.id === indexString ? accordionRef.current.scrollIntoView({ behavior: 'smooth' }) : null; | ||
openState.toggle(); | ||
accordionRef.current?.id === indexString ? | ||
accordionRef.current.scrollIntoView({ block: 'center', behavior: 'smooth' }) | ||
: null; | ||
} | ||
}; | ||
|
||
|
@@ -167,8 +159,10 @@ const hashOnClick = ( | |
setClipboardContents: (currentSchema: string) => void, | ||
) => { | ||
event.stopPropagation(); | ||
window.location.hash = windowLocationHash; | ||
setClipboardContents(window.location.href); | ||
event.preventDefault(); | ||
setClipboardContents( | ||
`${window.location.origin}${window.location.pathname}${window.location.search}${windowLocationHash}`, | ||
); | ||
}; | ||
|
||
const AccordionItem = ({ index, accordionData, openState }: AccordionItemProps) => { | ||
|
@@ -182,36 +176,38 @@ const AccordionItem = ({ index, accordionData, openState }: AccordionItemProps) | |
const windowLocationHash = `#${index}`; | ||
|
||
useEffect(() => { | ||
handleInitialHashCheck(windowLocationHash, accordionData, openState, indexString, accordionRef); | ||
setTimeout(() => { | ||
handleInitialHashCheck(windowLocationHash, openState, indexString, accordionRef); | ||
}, 100); | ||
Comment on lines
+179
to
+181
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Set timeout is needed since there is some timing issue with rendering the accordion and scrolling into view and making sure it opens |
||
}, []); | ||
|
||
return ( | ||
<li ref={accordionRef} role="button" css={accordionItemStyle(theme)} id={indexString} onClick={openState.toggle}> | ||
<div css={accordionItemTitleStyle}> | ||
<div css={contentContainerStyle}> | ||
<div css={titleRowStyle}> | ||
<button type="button" css={accordionItemButtonStyle(theme)}> | ||
<button css={accordionItemButtonStyle(theme)}> | ||
<ChevronDown | ||
fill={theme.colors.accent_dark} | ||
width={16} | ||
height={16} | ||
style={chevronStyle(openState.isOpen)} | ||
/> | ||
<span>{title}</span> | ||
</button> | ||
<span css={titleStyle(theme)}>{title}</span> | ||
<button | ||
type="button" | ||
css={hashIconStyle(theme)} | ||
onClick={(event) => hashOnClick(event, windowLocationHash, setClipboardContents)} | ||
> | ||
<Hash width={20} height={20} fill={theme.colors.secondary} /> | ||
</button> | ||
<ReadMoreText maxLines={MAX_LINES_BEFORE_EXPAND} wrapperStyle={descriptionWrapperStyle}> | ||
{description} | ||
</ReadMoreText> | ||
</div> | ||
<ReadMoreText maxLines={MAX_LINES_BEFORE_EXPAND} wrapperStyle={descriptionWrapperStyle}> | ||
{description} | ||
</ReadMoreText> | ||
</div> | ||
<div css={downloadButtonContainerStyle}> | ||
<div> | ||
{/* Mock props for the dictionary since we haven't implemented the download per schema yet */} | ||
<DictionaryDownloadButton | ||
lecternUrl="" | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not needed