WIP: DEMO branch with css fixes #298
Draft
+491
−475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…use it for action items
…tents and update the stories
…r-dropdown Fix naming for list comopnent
… better organization
…per clickability as well as make it visually appealing
… added and did not have a pattern
…is still not working as intended....
SaqAsh
commented
Jul 14, 2025
Comment on lines
+179
to
+181
| setTimeout(() => { | ||
| handleInitialHashCheck(windowLocationHash, openState, indexString, accordionRef); | ||
| }, 100); |
There was a problem hiding this comment.
Set timeout is needed since there is some timing issue with rendering the accordion and scrolling into view and making sure it opens
SaqAsh
commented
Jul 14, 2025
Comment on lines
-63
to
-66
| overflow-x: auto; | ||
| overflow-y: visible; | ||
| box-shadow: 0 2px 4px rgba(0, 0, 0, 0.1); | ||
| position: relative; |
There was a problem hiding this comment.
This is what fixed the issue with the overlaying, critical fix
SaqAsh
commented
Jul 14, 2025
|
|
||
| import AccordionItem from './AccordionItem'; | ||
|
|
||
| export type AccordionData = { | ||
| title: string; | ||
| openOnInit: boolean; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Issues
Description of Changes
Readiness Checklist
.env.schemafile and documented in the README