Skip to content

An alternative implementation of a type for HGC/CALOROC output #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

An alternative implementation of a type for HGC/CALOROC output #116

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fe0f783
Add reworked CALOROC proposal
ruse-traveler Jun 9, 2025
f5b28f1
Remove CALOROC mention
ruse-traveler Jun 30, 2025
f740237
Update author list
ruse-traveler Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions edm4eic.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,15 @@ components:
- uint32_t boundValuesSize // size of bound values
- std::array<double,16> transform // row-wise 4x4 affine transform [R T; 0 1] with 3x3 rotation matrix R and translation column 3-vector T

## An individual sample output by an HGCROC chip
edm4eic::HGCROCSample:
Members:
- uint16_t ADC // [ADC Counts], amplitude of signal during sample, valid IFF TOTInProgress is false
- uint16_t timeOfArrival // Time of arrival (TOA) [TDC counts], nonzero IFF ADC crossed threshold upwards during sample
- uint16_t timeOverThreshold // Time over threshold (TOT) [TDC counts], nonzero IFF ADC crossed threshold downwards during sample AND if TOA fired in a previous sample
- bool TOTInProgress // Flag which indicates if a TOT fired in a previous sample and calculation is ongoing, ADC value may be corrupted if this is true
- bool TOTComplete // Flag which indicates if a TOT calculation is complete and TOT value is valid

datatypes:

edm4eic::Tensor:
Expand Down Expand Up @@ -265,6 +274,17 @@ datatypes:
## ==========================================================================
## Calorimetry
## ==========================================================================

edm4eic::RawHGCROCHit:
Description: "Raw hit from an HGCROC chip"
Author: "D. Anderson, S. Joosten, T. Protzman, N. Novitzky, D. Kalinkin"
Members:
- uint64_t cellID // Detector specific (geometrical) cell id
- int32_t samplePhase // Phase of samples in [# samples], for synchronizing across chips
- int32_t timeStamp // [TDC counts]
VectorMembers:
- edm4eic::HGCROCSample sample // ADC, Time of Arrival (TOA), and Time over Threshold (TOT) values for each sample read out

edm4eic::CalorimeterHit:
Description: "Calorimeter hit"
Author: "W. Armstrong, S. Joosten"
Expand Down