-
Notifications
You must be signed in to change notification settings - Fork 5
An alternative implementation of a type for HGC/CALOROC output #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
edm4eic.yaml
Outdated
## An individual sample output by a HGC/CALOROC chip | ||
edm4eic::CALOROCSample: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## An individual sample output by a HGC/CALOROC chip | |
edm4eic::CALOROCSample: | |
## An individual sample output by a HGCROC chip | |
edm4eic::HGCROCSample: |
As discussed, we don't know much about CALOROC, so this is HGCROC
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True! I left it as CALOROC
largely just for parallelism with the original PR. I'm fine with changing it to HGCROC
, since (as you note) this is explicitly inspired by the existing HGCROC!
edm4eic.yaml
Outdated
edm4eic::RawCALOROCHit: | ||
Description: "Raw hit from a CALOROC/HGCROC chip" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
edm4eic::RawCALOROCHit: | |
Description: "Raw hit from a CALOROC/HGCROC chip" | |
edm4eic::RawHGCROCHit: | |
Description: "Raw hit from a HGCROC chip" |
edm4eic.yaml
Outdated
- int32_t samplePhase // Phase of samples in [# samples], for synchronizing across chips | ||
- int32_t timeStamp // [TDC counts] | ||
VectorMembers: | ||
- edm4eic::CALOROCSample sample // ADC, Time of Arrival (TOA), and Time over Threshold (TOT) values for each sample read out |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- edm4eic::CALOROCSample sample // ADC, Time of Arrival (TOA), and Time over Threshold (TOT) values for each sample read out | |
- edm4eic::HGCROCSample sample // ADC, Time of Arrival (TOA), and Time over Threshold (TOT) values for each sample read out |
Briefly, what does this PR introduce?
This PR introduces two types to facilitate work with the output of HGC/CALOROC chips:
edm4eic::CALOROCSample
, which defines for a given sample read out by the a chipedm4eic::RawCALOROCHit
, which consolidates for a given hitThis PR is intended to supersede #101. It makes two distinct design choices from #101 informed by experience from the 2024 LFHCAL and EEEMCal test beams, both of which utilized HGCROC prototypes.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
No.