Skip to content

Trim spaces in Proof ID for verification #1231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Trim spaces in Proof ID for verification #1231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5e0a9ed
Started working on proof id trim issue
kirti763 May 7, 2025
6591626
Create README.md
kirti763 May 7, 2025
ee7be0e
temp update to trigger draft PR
kirti763 May 7, 2025
c03083c
fix: trim proofId to avoid 500 error on verify endpoint
kirti763 May 11, 2025
ea4d5f5
Resolved merge conflict in README.md
kirti763 May 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,4 +106,5 @@ Pull requests are welcome! Please read our [contributions guide](https://github.

## License

[Apache License Version 2.0](https://github.com/credebl/platform/blob/main/LICENSE)
[Apache License Version 2.0](https://github.com/credebl/platform/blob/main/LICENSE)

3 changes: 2 additions & 1 deletion apps/api-gateway/src/verification/verification.controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,9 +373,10 @@ export class VerificationController {
async verifyPresentation(
@Res() res: Response,
@User() user: IUserRequest,
@Param('proofId') proofId: string,
@Param('proofId') rawProofId: string,
@Param('orgId') orgId: string
): Promise<Response> {
const proofID = rawProofID.trim();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of a trim, we can utilize the already present validation pipe

const verifyData = await this.verificationService.verifyPresentation(proofId, orgId, user);
const finalResponse: IResponse = {
statusCode: HttpStatus.CREATED,
Expand Down