Trim spaces in Proof ID for verification #1231
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kirti Goyal <94823738+kirti763@users.noreply.github.com>
|
|
Hello @kirti763, Thanks for your interest. |
|
Hey @bhavanakarwade just checking in. Are there any updates regarding my PR |
|
Hello @kirti763 Apologies for the delay, there were some releases we were working on which, required not merging PR. Just a small request, do you mind creating a PR, against the |
GHkrishna
requested changes
Jul 11, 2025
| @Param('orgId') orgId: string | ||
| ): Promise<Response> { | ||
| const proofID = rawProofID.trim(); |
There was a problem hiding this comment.
Instead of a trim, we can utilize the already present validation pipe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses an issue where spaces before a proof ID were causing a 500 error during verification. The issue was fixed by trimming any leading from the provided proof ID before it is used in the verification process.
Changes made:
proofIdbefore calling the verification service.Issue Reference: