-
Notifications
You must be signed in to change notification settings - Fork 1
Ascend npu/torchtitan #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lowdy1
wants to merge
9
commits into
main
Choose a base branch
from
ascend-npu/torchtitan
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
8fbc305
NPU add titan test
lowdy1 c253f09
NPU add torchtitan test
lowdy1 29f77f4
NPU add titan test
lowdy1 964ca76
add torchtitan
lowdy1 7a515a4
titan test
lowdy1 1c6cf7f
after rebasing
lowdy1 ae72ad3
use 2 npus
lowdy1 43b0bfd
add installments
lowdy1 99b1bb6
change runner
lowdy1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -120,6 +120,40 @@ jobs: | |||||
image: ${{ needs.prepare.outputs.image }} | ||||||
torch-artifact: ${{ needs.build-torch.outputs.torch-artifact }} | ||||||
|
||||||
test: | ||||||
name: Test torch_npu | ||||||
needs: | ||||||
- prepare | ||||||
- build-torch | ||||||
- build | ||||||
if: | | ||||||
!cancelled() && github.event_name != 'repository_dispatch' && | ||||||
(success() || (needs.build-torch.result == 'skipped' && needs.build.result == 'success')) | ||||||
uses: ./.github/workflows/_ascend_npu_ut.yml | ||||||
with: | ||||||
runner: ${{ needs.prepare.outputs.runner }} | ||||||
image: ${{ needs.prepare.outputs.image }} | ||||||
torch-artifact: ${{ needs.build-torch.outputs.torch-artifact }} | ||||||
torch-npu-artifact: ${{ needs.build.outputs.torch-npu-artifact }} | ||||||
|
||||||
benchmark: | ||||||
name: Run benchmarks | ||||||
needs: | ||||||
- prepare | ||||||
- build-torch | ||||||
- build | ||||||
if: | | ||||||
!cancelled() && github.event_name != 'repository_dispatch' && | ||||||
(success() || (needs.build-torch.result == 'skipped' && needs.build.result == 'success')) | ||||||
uses: ./.github/workflows/_ascend_npu_benchmark.yml | ||||||
with: | ||||||
runner: ${{ needs.prepare.outputs.runner }} | ||||||
image: ${{ needs.prepare.outputs.image }} | ||||||
torch-artifact: ${{ needs.build-torch.outputs.torch-artifact }} | ||||||
torch-npu-artifact: ${{ needs.build.outputs.torch-npu-artifact }} | ||||||
secrets: | ||||||
pr-token: ${{ secrets.COSDT_BOT_TOKEN }} | ||||||
|
||||||
torchtitan: | ||||||
name: Run torchtitan | ||||||
needs: | ||||||
|
@@ -135,4 +169,5 @@ jobs: | |||||
image: ${{ needs.prepare.outputs.image }} | ||||||
torch-artifact: ${{ needs.build-torch.outputs.torch-artifact }} | ||||||
torch-npu-artifact: ${{ needs.build.outputs.torch-npu-artifact }} | ||||||
|
||||||
secrets: | ||||||
pr-token: ${{ secrets.COSDT_BOT_TOKEN }} | ||||||
Comment on lines
+172
to
+173
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I believe this is redundant. It's never be used.
Suggested change
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.