Ascend npu/torchtitan #61
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shink
reviewed
Jun 5, 2025
| with: | ||
| runner: ${{ needs.prepare.outputs.runner }} | ||
| image: ${{ needs.prepare.outputs.image }} | ||
| device: ${{ needs.prepare.outputs.device }} |
There was a problem hiding this comment.
device is unused
Suggested change
| device: ${{ needs.prepare.outputs.device }} |
shink
requested changes
Jun 5, 2025
Comment on lines
14
to
17
| device: | ||
| required: true | ||
| type: string | ||
| description: "The device selected to run on" |
There was a problem hiding this comment.
Please DO NOT add this arg, see: #60
Comment on lines
14
to
17
| device: | ||
| required: true | ||
| type: string | ||
| description: "The device selected to run on" |
There was a problem hiding this comment.
Suggested change
| device: | |
| required: true | |
| type: string | |
| description: "The device selected to run on" |
shink
reviewed
Jun 5, 2025
Comment on lines
31
to
38
| # Bash shells do not use ~/.profile or ~/.bashrc so these shells need to be explicitly | ||
| # declared as "shell: bash -el {0}" on steps that need to be properly activated. | ||
| # It's used to activate ascend-toolkit environment variables. | ||
|
|
||
| defaults: | ||
| run: | ||
| shell: bash -el {0} | ||
|
|
There was a problem hiding this comment.
This is deprecated too
Suggested change
| # Bash shells do not use ~/.profile or ~/.bashrc so these shells need to be explicitly | |
| # declared as "shell: bash -el {0}" on steps that need to be properly activated. | |
| # It's used to activate ascend-toolkit environment variables. | |
| defaults: | |
| run: | |
| shell: bash -el {0} |
lowdy1
force-pushed
the
ascend-npu/torchtitan
branch
from
80652de to
1c6cf7f
Compare
shink
reviewed
Jun 11, 2025
| @@ -127,7 +119,7 @@ jobs: | |||
|
|
|||
| - name: Run torchtitan integration_test | |||
| working-directory: torchtitan | |||
| run: | | |||
| run: | | |||
There was a problem hiding this comment.
Suggested change
| run: | | |
| run: | |
shink
reviewed
Jun 11, 2025
Comment on lines
+172
to
+173
| secrets: | ||
| pr-token: ${{ secrets.COSDT_BOT_TOKEN }} |
There was a problem hiding this comment.
I believe this is redundant. It's never be used.
Suggested change
| secrets: | |
| pr-token: ${{ secrets.COSDT_BOT_TOKEN }} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.