Skip to content

refactor: replace append slice manipulation with slices.Delete #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor: replace append slice manipulation with slices.Delete #723

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions pkg/bandrng/sampling.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package bandrng

import (
"math"
"slices"
)

// safeAdd performs the addition operation on two uint64 integers, but panics if overflow.
Expand Down Expand Up @@ -46,8 +47,8 @@ func ChooseSome(rng *Rng, weights []uint64, cnt int) []int {
for round := 0; round < cnt; round++ {
chosen := ChooseOne(rng, availableWeights)
chosenIndexes[round] = availableIndexes[chosen]
availableWeights = append(availableWeights[:chosen], availableWeights[chosen+1:]...)
availableIndexes = append(availableIndexes[:chosen], availableIndexes[chosen+1:]...)
availableWeights = slices.Delete(availableWeights, chosen, chosen+1)
availableIndexes = slices.Delete(availableIndexes, chosen, chosen+1)
}
return chosenIndexes
}
Expand Down