Skip to content

Feat: use jnml from pyneuroml #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 3, 2025

Conversation

sanjayankur31
Copy link
Contributor

Depends on: NeuroML/pyNeuroML#450

@sanjayankur31
Copy link
Contributor Author

This now requires pyneuroml>=1.3.19. I don't think there's a way of saying that in omv, but all users should get the new pyneuroml version from now, so it should be OK.

I am wondering if the pip commands in omv should include a --upgrade if no version information is provided, otherwise, it will be happy with an older version of a package?

@sanjayankur31
Copy link
Contributor Author

I cut a new pyneuroml release that provides the jnml wrapper, so this is now ready for review.

@sanjayankur31 sanjayankur31 merged commit a2f1b97 into development Jul 3, 2025
45 checks passed
@sanjayankur31 sanjayankur31 deleted the feat-use-jnml-from-pyneuroml branch July 3, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant