Feat: provide jnml command that will use the bundled jar
#450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PyNeuroML will provide a `jnml` command too, which will use the bundled jNeuroML jar file. Note that to use another jnml, such as one from the jNeuroML release tar, one can simply either use the full path, or modify the $PATH etc. variables that are available on most systems.
This ensures that the output matches what running `jnml` from the jNeuroML repo would show. This is required for omv etc. to continue functioning as is.
sanjayankur31
added a commit
to OpenSourceBrain/osb-model-validation
that referenced
this pull request
Jun 12, 2025
|
This seems to work fine, along with OpenSourceBrain/osb-model-validation#138 Should I merge and cut a release @pgleeson ? |
So that other things depending on it, like omv, get the right exit code to process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works fine, but it'll be good to see if it breaks any workflows---omv for example should just find this wrapper now and work with it, but we should just test it out a little.