Dark titlebar

CHANGELOG.md

@@ -37,6 +37,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv
 - We added functionality to focus running instance when trying to start a second instance. [#13129](https://github.com/JabRef/jabref/issues/13129)
 - We added a new setting in the 'Entry Editor' preferences to hide the 'File Annotations' tab when no annotations are available. [#13143](https://github.com/JabRef/jabref/issues/13143)
 - We added support for multi-file import across different formats. [#13269](https://github.com/JabRef/jabref/issues/13269)
+- We added support for Windows dark title bar. [#11457](https://github.com/JabRef/jabref/issues/11457)
 
 ### Changed
 

jabgui/build.gradle.kts

@@ -24,6 +24,8 @@ dependencies {
     implementation("org.openjfx:javafx-swing")
     implementation("org.openjfx:javafx-web")
 
+    implementation("com.pixelduke:fxthemes:1.6.0")
+
     implementation("org.slf4j:slf4j-api")
     implementation("org.tinylog:tinylog-api")
     implementation("org.tinylog:slf4j-tinylog")

jabgui/src/main/java/module-info.java

@@ -180,13 +180,15 @@
 
     // region: other libraries (alphabetically)
     // requires cuid;
+    requires com.dlsc.pdfviewfx;
+    requires com.pixelduke.fxthemes;
+    // requires com.sun.jna;
     // requires dd.plist;
     requires io.github.adr;
     // required by okhttp and some AI library
     // requires kotlin.stdlib;
     // requires mslinks;
     requires org.antlr.antlr4.runtime;
     requires org.libreoffice.uno;
-    requires com.dlsc.pdfviewfx;
     // endregion
 }

jabgui/src/main/java/org/jabref/gui/theme/ThemeManager.java

@@ -13,19 +13,25 @@
 
 import javafx.application.ColorScheme;
 import javafx.application.Platform;
+import javafx.collections.ListChangeListener;
 import javafx.scene.Node;
 import javafx.scene.Scene;
 import javafx.scene.web.WebEngine;
+import javafx.stage.Stage;
+import javafx.stage.Window;
 
 import org.jabref.gui.WorkspacePreferences;
 import org.jabref.gui.icon.IconTheme;
 import org.jabref.gui.util.BindingsHelper;
 import org.jabref.gui.util.UiTaskExecutor;
 import org.jabref.logic.l10n.Localization;
+import org.jabref.logic.os.OS;
 import org.jabref.model.util.FileUpdateListener;
 import org.jabref.model.util.FileUpdateMonitor;
 
 import com.google.common.annotations.VisibleForTesting;
+import com.pixelduke.window.ThemeWindowManager;
+import com.pixelduke.window.ThemeWindowManagerFactory;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -49,13 +55,16 @@ public class ThemeManager {
     );
 
     private static final Logger LOGGER = LoggerFactory.getLogger(ThemeManager.class);
+    private static final boolean SUPPORTS_DARK_MODE = OS.WINDOWS || OS.OS_X;
 
     private final WorkspacePreferences workspacePreferences;
     private final FileUpdateMonitor fileUpdateMonitor;
     private final Consumer<Runnable> updateRunner;
+    private final ThemeWindowManager themeWindowManager;
 
     private final StyleSheet baseStyleSheet;
     private Theme theme;
+    private boolean isDarkMode;
 
     private Scene mainWindowScene;
     private final Set<WebEngine> webEngines = Collections.newSetFromMap(new WeakHashMap<>());
@@ -66,9 +75,13 @@ public ThemeManager(WorkspacePreferences workspacePreferences,
         this.workspacePreferences = Objects.requireNonNull(workspacePreferences);
         this.fileUpdateMonitor = Objects.requireNonNull(fileUpdateMonitor);
         this.updateRunner = Objects.requireNonNull(updateRunner);
+        this.themeWindowManager = ThemeWindowManagerFactory.create();
 
         this.baseStyleSheet = StyleSheet.create(Theme.BASE_CSS).get();
         this.theme = workspacePreferences.getTheme();
+        this.isDarkMode = Theme.EMBEDDED_DARK_CSS.equals(this.theme.getName());
+
+        initializeWindowThemeUpdater(this.isDarkMode);
 
         // Watching base CSS only works in development and test scenarios, where the build system exposes the CSS as a
         // file (e.g. for Gradle run task it will be in build/resources/main/org/jabref/gui/Base.css)
@@ -83,6 +96,58 @@ public ThemeManager(WorkspacePreferences workspacePreferences,
         updateThemeSettings();
     }
 
+    private void initializeWindowThemeUpdater(boolean darkMode) {
+        if (!SUPPORTS_DARK_MODE) {
+            return;
+        }
+
+        this.isDarkMode = darkMode;
+
+        ListChangeListener<Window> windowsListener = change -> {
+            while (change.next()) {
+                if (!change.wasAdded()) {
+                    continue;
+                }
+                change.getAddedSubList().stream()
+                      .filter(Stage.class::isInstance)
+                      .map(Stage.class::cast)
+                      .forEach(stage -> {
+                          BindingsHelper.subscribeFuture(stage.showingProperty(), showing -> {
+                              if (showing) {
+                                  applyDarkModeToWindow(stage, isDarkMode);
+                              }
+                          });
+                          if (stage.isShowing()) {
+                              applyDarkModeToWindow(stage, isDarkMode);
+                          }
+                      });
+            }
+        };
+
+        Window.getWindows().addListener(windowsListener);
+        applyDarkModeToAllWindows(darkMode);
+
+        LOGGER.debug("Window theme monitoring initialized");
+    }
+
+    private void applyDarkModeToWindow(Stage stage, boolean darkMode) {
+        if (!SUPPORTS_DARK_MODE || stage == null || !stage.isShowing()) {
+            return;
+        }
+
+        themeWindowManager.setDarkModeForWindowFrame(stage, darkMode);
+        LOGGER.debug("Applied {} mode to window: {}", darkMode ? "dark" : "light", stage);
+    }
+
+    private void applyDarkModeToAllWindows(boolean darkMode) {
+        this.isDarkMode = darkMode;
+        Window.getWindows().stream()
+              .filter(Window::isShowing)
+              .filter(window -> window instanceof Stage)
+              .map(window -> (Stage) window)
+              .forEach(stage -> applyDarkModeToWindow(stage, darkMode));
+    }
+
     private void updateThemeSettings() {
         Theme newTheme = Objects.requireNonNull(workspacePreferences.getTheme());
 
@@ -103,6 +168,12 @@ private void updateThemeSettings() {
         this.theme = newTheme;
         LOGGER.info("Theme set to {} with base css {}", newTheme, baseStyleSheet);
 
+        boolean isDarkTheme = Theme.EMBEDDED_DARK_CSS.equals(newTheme.getName());
+        if (this.isDarkMode != isDarkTheme) {
+            this.isDarkMode = isDarkTheme;
+            applyDarkModeToAllWindows(isDarkTheme);
+        }
+
         this.theme.getAdditionalStylesheet().ifPresent(
                 styleSheet -> addStylesheetToWatchlist(styleSheet, this::additionalCssLiveUpdate));