Dark titlebar #13386

Yubo-Cao · 2025-06-21T03:56:22Z

Closes #11457

Added a dark mode title bar for Windows.

Steps to test

Run JabRef with this version of the code
Open preferences, change theme to dark/light
The title bar should toggle if using Windows

A screenshot can be found here: https://imgur.com/a/aLDeZqg

Mandatory checks

I own the copyright of the code submitted and I license it under the MIT license
Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
[/] Tests created for changes (if applicable)
Manually tested changed features in running JabRef (always required)
Screenshots added in PR description (if change is visible to the user)
[/] Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
[/] Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

calixtus · 2025-06-21T06:50:17Z

This seems to be too much micromanagement here. as this needs to be maintained in future.
We should rely on a library instead here.
Use FXThemes from Pixelduke. https://www.pixelduke.com/2024/05/02/fxthemes-version-1-5-released/

calixtus · 2025-06-21T06:56:07Z

Do not introduce custom monitoring, use proper bindings in javafx' platfrom api.
https://download.java.net/java/GA/javafx24/docs/api/javafx.graphics/javafx/application/Platform.Preferences.html#colorSchemeProperty

Siedlerchr · 2025-06-21T09:13:44Z

FxTheme does the same and we would just introduce another dependency.
One could also take a look at how xpipe does this https://github.com/xpipe-io/xpipe/blob/8389c4073bbc7e69cfeb7cf329fcabb666f9c338/app/src/main/java/io/xpipe/app/core/window/NativeWinWindowControl.java because then it could work for mac as well

calixtus · 2025-06-21T12:13:25Z

Yes, but fxtheme is not maintained by us. Introducing a new library is in that case not necessary, if another library already supports what we need. But in this case, I have no interest in fixing changing apis and keeping it compatible to other OSs. That is what literally using an external library is meant for.

jabgui/src/main/java/org/jabref/gui/desktop/os/ThemeListener.java

jabgui/src/main/java/org/jabref/gui/theme/ThemeManager.java

calixtus · 2025-06-21T19:26:24Z

jabgui/src/main/java/org/jabref/gui/theme/ThemeManager.java

+        ListChangeListener<Window> windowsListener = change -> {
+            while (change.next()) {
+                if (!change.wasAdded()) {
+                    continue;
+                }
+                change.getAddedSubList().stream()
+                      .filter(Stage.class::isInstance)
+                      .map(Stage.class::cast)
+                      .forEach(stage -> {
+                          BindingsHelper.subscribeFuture(stage.showingProperty(), showing -> {
+                              if (showing) {
+                                  applyDarkModeToWindow(stage, isDarkMode);
+                              }
+                          });
+                          if (stage.isShowing()) {
+                              applyDarkModeToWindow(stage, isDarkMode);
+                          }
+                      });
+            }
+        };


can maybe simplified with platform preferences api

I don't understand why the platform preferences API would work? The dark title bar must be applied to each new window, nor does the platform preferences API understand "use system theme" settings in the JabRef application.

The platform preferences provide the binding colorSchemeProperty, which can be subscribed to, which notifies you every time the color scheme is changed in the system settings. Only thing left is if the user manually changes the theme in JabRef itself.

Aah, wait... Maybe there is no something I overlooked.... Right now I'm on my cellphone, I will take a deeper look in a few hours

jabgui/src/main/java/org/jabref/gui/theme/ThemeManager.java

jabgui/build.gradle.kts

koppor · 2025-06-22T16:48:12Z

jabgui/src/main/java/org/jabref/gui/theme/ThemeManager.java

@@ -49,13 +55,16 @@ public class ThemeManager {
    );

    private static final Logger LOGGER = LoggerFactory.getLogger(ThemeManager.class);
+    private static final boolean SUPPORTS_DARK_MODE = OS.WINDOWS || OS.OS_X;


Please comment why it is not supported on Linux. Add a link. I think, KDE supports dark mode, doesn't it?

This reminded me that there is a thing they are working on https://bugs.openjdk.org/browse/JDK-8313424

Linux would automatically enforce a dark/light titlebar based on the system settings. The actual implementation of FXThemes on a Linux environment is a method that is empty. https://github.com/dukke/FXThemes/blob/main/FXThemes/src/main/java/com/pixelduke/window/LinuxThemeWindowManager.java

Would it be better for me to just have called the stub methods anyway?

Would it be better for me to just have called the stub methods anyway

Yes, I think so. Maybe, there are some Window managers we never thought of supported? Icewm, dwm, ...

calixtus · 2025-06-22T19:48:43Z

jabgui/src/main/java/org/jabref/gui/theme/ThemeManager.java

+                          BindingsHelper.subscribeFuture(stage.showingProperty(), showing -> {
+                              if (showing) {
+                                  applyDarkModeToWindow(stage, isDarkMode);
+                              }
+                          });
+                          if (stage.isShowing()) {
+                              applyDarkModeToWindow(stage, isDarkMode);
+                          }


duplication can be solved with EasyBind::subscribe

i'm not sure but i think this may cause a memory leak. if a window is closed, the reference is not removed and the garbage collector wont remove this. or am i wrong here? @Siedlerchr @koppor

@Yubo-Cao do not close converstations with questions raised that have not been answered. Maybe you already know, but I want to know.

Sorry, I thought the code was updated such that this duplication is not present, so this conversation is no longer relevant. But I think it's unlikely that we will have a memory leak, since this listener is anonymous, so the only reference to the window object would be inside the list of listeners that the window object creates for itself, which won't prevent the window from being recycled.

For resolving just write a "done" or something like this if you addressed the comment

Siedlerchr · 2025-06-24T19:26:14Z

Doesn't seem to make any difference on macOS

Only if my system theme is set to dark mode it gets a dark color:

Yubo-Cao · 2025-06-24T21:46:48Z

Doesn't seem to make any difference on macOS

Only if my system theme is set to dark mode it gets a dark color:

... I cannot really test how the application behaves on Mac. But just to confirm, can you try setting the theme to dark in the settings, then set it back to light and see if that makes a difference?

Siedlerchr · 2025-06-25T18:47:11Z

Didn't really make any difference so far, I also don't know if that should work on newer macs or not. No idea

CHANGELOG.md

Co-authored-by: Subhramit Basu <subhramit.bb@live.in>

trag-bot · 2025-06-29T00:38:39Z

@trag-bot didn't find any issues in the code! ✅✨

jabref-machine · 2025-06-29T00:41:28Z

JUnit tests of jabkit are failing. You can see which checks are failing by locating the box "Some checks were not successful" on the pull request page. To see the test output, locate "Tests / Unit tests (pull_request)" and click on it.

You can then run these tests in IntelliJ to reproduce the failing tests locally. We offer a quick test running howto in the section Final build system checks in our setup guide.

Yubo-Cao added 2 commits June 20, 2025 23:42

Add dark mode window title bar

da017b6

Update CHANGELOG.md

b442fc8

Use FXThemes instead

40479ff

trag-bot bot reviewed Jun 21, 2025

View reviewed changes

jabgui/src/main/java/org/jabref/gui/desktop/os/ThemeListener.java Outdated Show resolved Hide resolved

Fix according to Trag

fbc6908

calixtus reviewed Jun 21, 2025

View reviewed changes

jabgui/src/main/java/org/jabref/gui/theme/ThemeManager.java Outdated Show resolved Hide resolved

calixtus reviewed Jun 21, 2025

View reviewed changes

Put themeWindowManager to the constructor

9e7bbb0

trag-bot bot reviewed Jun 21, 2025

View reviewed changes

jabgui/src/main/java/org/jabref/gui/theme/ThemeManager.java Outdated Show resolved Hide resolved

koppor reviewed Jun 22, 2025

View reviewed changes

jabgui/build.gradle.kts Outdated Show resolved Hide resolved

Yubo-Cao added 2 commits June 22, 2025 10:42

Update to the latest version of pixelduke:fxthemes

1f6e3e1

Fix according to OpenRewrite

19d2c13

koppor reviewed Jun 22, 2025

View reviewed changes

calixtus reviewed Jun 22, 2025

View reviewed changes

Remove unnecessary checks

21dc53f

subhramit reviewed Jun 28, 2025

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Update CHANGELOG.md

1f0b87a

Co-authored-by: Subhramit Basu <subhramit.bb@live.in>

Uh oh!

Dark titlebar #13386

Are you sure you want to change the base?

Dark titlebar #13386

Uh oh!

Conversation

Yubo-Cao commented Jun 21, 2025

Steps to test

Mandatory checks

Uh oh!

calixtus commented Jun 21, 2025

Uh oh!

calixtus commented Jun 21, 2025

Uh oh!

Siedlerchr commented Jun 21, 2025

Uh oh!

calixtus commented Jun 21, 2025

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Siedlerchr Jun 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Yubo-Cao Jun 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Siedlerchr commented Jun 24, 2025

Uh oh!

Yubo-Cao commented Jun 24, 2025

Uh oh!

Siedlerchr commented Jun 25, 2025

Uh oh!

Uh oh!

trag-bot bot commented Jun 29, 2025

Uh oh!

jabref-machine commented Jun 29, 2025

Uh oh!

Uh oh!

Siedlerchr Jun 22, 2025 •

edited

Loading

Yubo-Cao Jun 22, 2025 •

edited

Loading