Skip to content

[Fix] OD-123 After comment overlay close items list wont disappear #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2020
Merged

[Fix] OD-123 After comment overlay close items list wont disappear #441

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions js/layout-javascript/news-feed-code.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,9 +438,8 @@ DynamicList.prototype.attachObservers = function() {
$(this).siblings('.panel-heading').find('.fa-angle-up').removeClass('fa-angle-up').addClass('fa-angle-down');
})
.on('click', '.news-feed-comment-holder', function(event) {
_this.$container.find('.news-feed-list-wrapper').hide();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tonytlwu please confirm you're good with this change

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with it. It was only added as part of #427 in this commit hidden amongst all other changes. It didn't seem necessary at the time and should be safe to remove.


event.stopPropagation();

var identifier;
if (_this.$container.find('.new-news-feed-list-container').hasClass('overlay-open')) {
identifier = $(this).parents('.news-feed-details-content-holder').data('entry-id');
Expand Down