[Fix] OD-123 After comment overlay close items list wont disappear #441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squallstar
previously approved these changes
Oct 5, 2020
squallstar
reviewed
Oct 5, 2020
| @@ -438,9 +438,8 @@ DynamicList.prototype.attachObservers = function() { | |||
| $(this).siblings('.panel-heading').find('.fa-angle-up').removeClass('fa-angle-up').addClass('fa-angle-down'); | |||
| }) | |||
| .on('click', '.news-feed-comment-holder', function(event) { | |||
| _this.$container.find('.news-feed-list-wrapper').hide(); | |||
There was a problem hiding this comment.
@tonytlwu please confirm you're good with this change
There was a problem hiding this comment.
I'm happy with it. It was only added as part of #427 in this commit hidden amongst all other changes. It didn't seem necessary at the time and should be safe to remove.
tonytlwu
approved these changes
Oct 5, 2020
There was a problem hiding this comment.
@sofiiakvasnevska This is ready for testing
Risk: Low
Affected: News feed LFD layout
Verify: LFD list works as normal when using the commenting feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sofiiakvasnevska
Issue
https://weboo.atlassian.net/browse/OD-123
Description
Removed news feed items hiding.
Screenshots/screencasts
https://share.getcloudapp.com/yAulowgz
Backward compatibility
This change is fully backward compatible.
Reviewers
@upplabs-alex-levchenko