[Feature] Allow users to use the keyboard to get access to the main features of the LFD. #427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonytlwu
reviewed
Sep 1, 2020
tonytlwu
requested changes
Sep 9, 2020
| @@ -247,7 +256,11 @@ DynamicList.prototype.attachObservers = function() { | |||
| } | |||
| }); | |||
| }) | |||
| .on('click', '.news-feed-detail-overlay-close, .news-feed-detail-overlay-screen', function(event) { | |||
| .on('click keydown', '.news-feed-detail-overlay-close, .news-feed-detail-overlay-screen', function(event) { | |||
| if (event.type !== 'click' && event.keyCode !== 32 && event.keyCode !== 13) { | |||
There was a problem hiding this comment.
Why isn't this updated too?
Suggested change
| if (event.type !== 'click' && event.keyCode !== 32 && event.keyCode !== 13) { | |
| if (!_this.Utils.Event.isExecute(event)) { |
There was a problem hiding this comment.
@tonytlwu removed
tonytlwu
approved these changes
Sep 10, 2020
There was a problem hiding this comment.
@sofiiakvasnevska This is ready for testing
Risk: High
Affected: All click-able features in LFD
Verify: Verify all click-able features in LFD work as usual
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sofiiakvasnevska
Issue
https://github.com/Fliplet/fliplet-studio/issues/6423
Description
Allow users to use the keyboard to get access to the main features of the LFD.
Screenshots/screencasts
https://share.getcloudapp.com/z8u82qKx
Backward compatibility
This change is fully backward compatible.
Reviewers
@upplabs-alex-levchenko
Notes
This PR should be merged before we merge this one