Skip to content

Update zh_cn.json #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 17, 2025
Merged

Update zh_cn.json #739

merged 5 commits into from
Jun 17, 2025

Conversation

GodGun968
Copy link
Contributor

No description provided.

@GodGun968 GodGun968 marked this pull request as ready for review June 14, 2025 10:09
Copy link
Owner

@Earthcomputer Earthcomputer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, there are some errors you need to fix:

 zh_cn.json:413: translation key 'twoPlayerGame.chat.won' does not have enough format specifiers. It only has 1 while the English has 2
zh_cn.json:413: translation key 'twoPlayerGame.chat.won' contains an unescaped '%'. Try escaping it with '%%'
zh_cn.json:415: translation key 'twoPlayerGame.incoming' does not have enough format specifiers. It only has 1 while the English has 2
zh_cn.json:415: translation key 'twoPlayerGame.incoming' contains an unescaped '%'. Try escaping it with '%%'

looks like you accidentally broke some %s format specifiers on line 413 and line 415.

@Earthcomputer
Copy link
Owner

See the translation guideline on string substitutions if you're confused

@GodGun968
Copy link
Contributor Author

Sorry, this is because there is similar content so I copied it directly but it was copied to the wrong location

@GodGun968
Copy link
Contributor Author

translation guideline

And the "use %1$s, %2$s, %3$s" is because the text was separated at the time and I had to translate it into such a word order. I actually prefer the word order of the original text

@GodGun968
Copy link
Contributor Author

And can you explain what "RNG call" means and what does "callback" do? It is best to have some demo video

@Earthcomputer
Copy link
Owner

can you explain what "RNG call" means

An "RNG call" in this context is a usage of the player RNG. Unexpected usages of the player RNG can mess up RNG manipulation because you're now in the wrong part of the RNG number sequence and will get different results.

what does "callback" do

/ccallback is a sort-of internal command to enable clientcommands to run code when you click on buttons in chat. The callback error will likely happen if the user tries to run the command directly without clientcommands having registered the callback. Microsoft seems to translate callback as "回拨", see their terminology search website

@GodGun968
Copy link
Contributor Author

/ccallback is a sort-of internal command to enable clientcommands to run code when you click on buttons in chat. The callback error will likely happen if the user tries to run the command directly without clientcommands having registered the callback.

well, I probably know how to translate it, but is there a demo video? what effect will it show?

ccallback -> 回调 RNG back -> RNG调用

Do you think this translation is appropriate? I remember there is such a thing in programming.

@Earthcomputer
Copy link
Owner

The callback has nothing to do with RNG, it's separate. It's a callback in the programming sense. Chatgpt says that how you have just translated it is good 👍

@GodGun968
Copy link
Contributor Author

call I didn't find it in the Wikipedia

callback

Is this explanation correct?

@Earthcomputer
Copy link
Owner

callback is correct. As for RNG call, I'm unable to provide much input on whether that's correct as I don't speak Chinese, but here's some advice from ChatGPT, feel free to ignore it in case it's speaking rubbish:
image

@GodGun968
Copy link
Contributor Author

OK Thank you for your review

The callback has nothing to do with RNG, it's separate. It's a callback in the programming sense. Chatgpt says that how you have just translated it is good 👍

@GodGun968
Copy link
Contributor Author

A piece of code is used to modify RNG. So because some behaviors in the game cause the modified RNG program to be called incorrectly, causing the RNG to change, so cannot be cracked.
Is this explanation correct?

@Earthcomputer
Copy link
Owner

Not really. Think of the RNG as a function which supplies random numbers. So an RNG call is a call (aka invocation) to this function. It's a function call, just like this:
image

@GodGun968
Copy link
Contributor Author

Oh, sorry I'm confused, so RNG itself is a piece of code, right?

@Earthcomputer
Copy link
Owner

Earthcomputer commented Jun 14, 2025

Yes, exactly, it's a piece of code which generates random numbers. And when you're doing RNG manipulation, you don't want to call that piece of code when you're not supposed to, and that is what this warning/error message is about. The warning says that the RNG function has been called when it wasn't supposed to have been called, and then %s is the thing that the player did to cause the RNG to have been called (e.g. sprinting).

@GodGun968
Copy link
Contributor Author

OK, just like I understand, so there is no problem with this translation

@Earthcomputer Earthcomputer merged commit d4d5a2a into Earthcomputer:fabric Jun 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants