Add heuristic for finding default remote name

[hyperupcall]

Description, Motivation and Context

Fixes #2317

Implementation:

• If HEAD is not detached, it infers the remote name by the current branch
• If HEAD is detached, then it infers the remote name by parsing git remote -v, but only if every entry has the same remote name

I've made similar PRs in other projects, so this does work in general.

How Has This Been Tested?

Manual testing

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• If my change requires a change to the documentation, I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
• I have added tests to cover my changes, and all the new and existing tests pass.

[seefood]

seems legit...

[seefood]

I looked over the repo, looks like there is already code covering remote name detection in themes/githelpers.theme.bash

Maybe it's not a bad idea for code reuse, to move this function library to the general libraries and have those functions available globally and not just for a small number of themes that bother to source it.

Any thoughts, @akinomyoga ?

[seefood]

(either way, if we keep this, maybe name it a bit more descrive, like _get_git_default_remote() )

[akinomyoga]

I think the target repositories are different. The functions _bash-it-{update-,version} modified in this PR are intended to retrieve the remote in the repository of Bash-It itself, while githelpers.theme.sh is supposed to retrieve information in the repository of the current working directory.

edit: I think it would be valid to prepare a function to get the remote name in the current git tree and use it everywhere. For the present purpose, the function can be used as $(cd "$BASH_IT"; _bash-it-git-get-remote-host). However, the feature to determine the remote name doesn't seem to exist in githelpers.theme.sh. I think unless the same feature is required by both themes and the bash-it command, we don't necessarily have to define the function in a single place.

[akinomyoga]

Doesn't this get the information about the git repository of the current working directory? Shouldn't this get the information in the Bash-it repository?

[seefood]

@hyperupcall ?

[akinomyoga]

I'm not sure how much the contribution guideline is strictly applied to the project, but Coding Style - docs/contributing.rst says

• When creating new functions, please use a dash ("-") to separate the words of the function's name, e.g. my-new-function. Don't use underscores, e.g. my_new_function.
• Internal functions that aren't to be used by the end user should start with an underscore, e.g. _my-new-internal-function.

[seefood]

yup, also maybe call it _get-git-default-remote-name is a bit more descriptive, and add a remark to doc the function.