Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not assume remote name is origin in remark-lint:awesome-github #170

Merged

Conversation

hyperupcall
Copy link
Contributor

@hyperupcall hyperupcall commented Sep 15, 2023

The rule remark-lint:awesome-github has false negatives when the remote name is origin. More detail in the linked issue.

Closes #169

@hyperupcall hyperupcall changed the title fix: Handle Git remotes with names other than origin In remark-lint:awesome-github, do not assume remote name is origin Sep 15, 2023
@hyperupcall hyperupcall changed the title In remark-lint:awesome-github, do not assume remote name is origin Do not assume remote name is origin in remark-lint:awesome-github Sep 15, 2023
@hyperupcall hyperupcall force-pushed the hyperupcall-allow-variable-remotes branch from 2f77dad to c437c4a Compare September 15, 2023 21:54
@hyperupcall
Copy link
Contributor Author

CI fails due to xo errors on unchanged files.

@sindresorhus sindresorhus merged commit c94b1c6 into sindresorhus:main Sep 21, 2023
0 of 3 checks passed
@hyperupcall hyperupcall deleted the hyperupcall-allow-variable-remotes branch September 21, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remark-lint:awesome-github gives false negative when remote name is not origin
2 participants