Boost: Add cleanup for expired concatenated file paths

[dilirity]

Fixes HOG-189

Proposed changes:

• Set expiry of concatenated options to 1 week (was previously 1 year);
• Add cleanup for concatenated options that have expired.

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

HOG-189

Does this pull request change what data or activity we track or use?

no

Testing instructions:

Pre-requisites

• Add this snippet to your site, to create some concatenated paths. Two of the file paths have expired so they should get deleted after cleanup runs:

add_action( 'template_redirect', function () {
	if ( ! isset( $_GET['jb-test-concat-cleanup'] ) ) {
		return;
	}

	$option_prefix = 'jb_transient_concat_paths_';

	for ( $i = 1; $i <= 6; $i++ ) {
		$option_name = $option_prefix . $i;
		$expire = time();

		// Make options 3+ (inclusive), expire later.
		if ( $i >= 3 ) {
			$expire += MONTH_IN_SECONDS;
		}

		$option_value = array(
			'expire' => $expire,
			'data' => array(
				'paths' => array(
					'script-path-1.js',
					'script-path-2.js',
				),
			),
		);

		update_option( $option_name, $option_value );
	}
} );

• Open your home page with the get param jb-test-concat-cleanup to trigger the script;
• Check the database for options with name LIKE jb_transient_c (or run this SQL query SELECT * FROM wp_optionsWHEREoption_name LIKE '%jb_transient_c%'. There should be 6 file path Boost transients:

• WP Crontrol plugin installed - it would make debugging schedules easier.

Test that cleanup works

• Setup Boost (free) from this branch;
• Open WP Admin -> Tools -> Cron Events and search for clean to make sure that jetpack_boost_minify_cron_cleanup_concat_paths and jetpack_boost_minify_cron_cleanup_concat_paths_followup are not in the list;
• Enable Concatenate JS (or Concatenate CSS);
• Check Tools -> Cron Events again and there should be an event called jetpack_boost_minify_cron_cleanup_concat_paths;
• Hover over the event, and click Run Now (to force schedule to run cleanup);
• Since WP schedules need a visit to the website, open the home page after you run the script (this will simulate a user/bot visit to the website);
• Now check the entries in the DB with the query from the Pre-Requisites section and entries 1 and 2 should be gone (you might see other entries, but that's probably because the home page visit concatenated some assets):

Test that cleanup schedules are removed

• Disable both Concatenate JS and Concatenate CSS;
• Visit Tools -> Cron Events and search for clean to make sure that jetpack_boost_minify_cron_cleanup_concat_paths and jetpack_boost_minify_cron_cleanup_concat_paths_followup are not in the list;
• Uninstalling Boost with either Concatenate JS or Concatenate CSS active should remove the schedules up as well.

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  
• ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
3. You can use GitHub's Reviewers functionality to request a review.
4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

---

Boost plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[jp-launch-control]

Code Coverage Summary

Coverage changed in 1 file.

File	Coverage	Δ%	Δ Uncovered
projects/plugins/boost/app/lib/minify/functions-helpers.php	0/143 (0.00%)	0.00%	3 ❤️‍🩹

1 file is newly checked for coverage.

File	Coverage
projects/plugins/boost/app/lib/minify/class-cleanup-stored-paths.php	0/40 (0.00%) 💔

Full summary · PHP report · JS report

_{Coverage check overridden by I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. .}

[LiamSarsfield]

LGTM besides the 2 comments, and works as expected once these are addressed. The suggestion code should also be updated to use $expire = time(); instead of $expire = time() + ( $i * DAY_IN_SECONDS )

[dilirity]

@LiamSarsfield thanks for the awesome idea with the offset!

I've implemented the change in 9598f32.