Boost: Update minify garbage collection to clean up files as well

[dilirity]

Caution

Merge this after #44134

Fixes HOG-190

Proposed changes:

• Remove stale static concatenated files when running garbage collection.

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

HOG-190

Does this pull request change what data or activity we track or use?

no

Testing instructions:

• Setup Boost (free) on this branch;
• Enable Concatenate JS/CSS;
• Visit a couple of pages so your website generates concatenated files and serves them from boost-cache/static;
• Now change this:

jetpack/projects/plugins/boost/app/lib/minify/class-cleanup-stored-paths.php

Line 84 in 0d859b4

$expire_timestamp = time() + MONTH_IN_SECONDS;

to

$expire_timestamp = time() + YEAR_IN_SECONDS;

This will force garbage collection to clean up any static files that were created, as it will treat them as expired.

• Force garbage collection to run (you can check the testing instructions in this PR - Boost: Add cleanup for expired concatenated file paths #44134)
• Files should get deleted after garbage collection finishes.

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  
• ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
3. You can use GitHub's Reviewers functionality to request a review.
4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

---

Boost plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[jp-launch-control]

Code Coverage Summary

No summary data is available for parent commit 9598f32, so cannot calculate coverage changes. 😴

If that commit is a feature branch rather than a trunk commit, this is expected. Otherwise, this should be updated once coverage for 9598f32 is available.

Full summary · PHP report · JS report

_{Coverage check overridden by I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. .}

[LiamSarsfield]

Just confirming here; It's not possible/extremely unlikely that there can be both a $hash.min.js, and a $hash.min.css? As if both exist, the CSS file will not be deleted

[dilirity]

I hadn't thought of that.

Though the hash is built from the path names of the assets and the modify time of the newest one.

I've updated this in 96338bd.