Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented SkipMultiCursorBack as a counterpart to SkipMultiCursor #3404

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

masmu
Copy link
Contributor

@masmu masmu commented Jul 28, 2024

This PR adds SkipMultiCursorBack as a counterpart to SkipMultiCursor.

Since Undo does not reverse selections, you are somehow stuck if you have used SkipMultiCursor incorrectly one too many times.

The name for this new action is up for debate. Since I didn't want to change the name of SkipMultiCursor I could not think of something better than SkipMultiCursorBack.

In case changing the name of SkipMultiCursor is an option i would throw the following candidates into the ring:

  • SkipNextMultiCursor and SkipPreviousMultiCursor
  • SkipMultiCursorForward and SkipMultiCursorBackward

@dmaluka
Copy link
Collaborator

dmaluka commented Sep 15, 2024

The name for this new action is up for debate. Since I didn't want to change the name of SkipMultiCursor I could not think of something better than SkipMultiCursorBack.

In case changing the name of SkipMultiCursor is an option i would throw the following candidates into the ring:

  • SkipNextMultiCursor and SkipPreviousMultiCursor
  • SkipMultiCursorForward and SkipMultiCursorBackward

To me SkipMultiCursorBack doesn't seem a very bad name. After all, what these 2 actions do is skip the current multicursor, not the next or previous one. (But I'd also welcome any better name suggestions.)

internal/action/actions.go Outdated Show resolved Hide resolved
@masmu masmu force-pushed the feature/skip-multi-cursor-back branch from b25eb52 to 2983f84 Compare September 15, 2024 13:42
internal/action/actions.go Outdated Show resolved Hide resolved
@masmu masmu force-pushed the feature/skip-multi-cursor-back branch from 2983f84 to ae26a01 Compare September 15, 2024 14:11
internal/action/actions.go Outdated Show resolved Hide resolved
@masmu masmu force-pushed the feature/skip-multi-cursor-back branch from ae26a01 to 12d8a4d Compare September 15, 2024 14:40
@dmaluka dmaluka requested a review from JoeKar September 15, 2024 14:45
Copy link
Collaborator

@JoeKar JoeKar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me too 👍.

@dmaluka dmaluka merged commit 4f4a13a into zyedidia:master Sep 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants