Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: issues found by code scanning #6992

Merged
merged 1 commit into from
Jul 9, 2024
Merged

fix: issues found by code scanning #6992

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/action-scripts/generateTypedDocs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ const checkPaths = ["docs/", "packages/*/*.api.md"];
* @param {{github: Github, context: Context}} param
*/
async function main(param) {
const { github, context } = param;
const { github } = param;

// check if our local working copy has any changes in the docs directory
const isChanged = !!(await exec.exec(
Expand Down
5 changes: 0 additions & 5 deletions .github/bot-scripts/ensureLogfileInDiscussion.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,11 +88,6 @@ Please consider uploading a logfile that captures your problem. As a reminder, h
}
}

const options = {
owner: context.repo.owner,
repo: context.repo.repo,
};

// TODO: Consider if we want to delete outdated comments. That may delete replies as well though.
if (hasZjsLog || !message) return;

Expand Down
2 changes: 1 addition & 1 deletion packages/eslint-plugin/src/utils/titleAndSentenceCase.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ function sentenceCaseWord(word: string, isFirstWord: boolean): string {
const exception = titleCaseExceptions.find(
(ex) => ex.toLowerCase() === lowercase,
);
if (exception) exception;
if (exception) return exception;
}
if (
titleCaseIgnored.some((re) => re.test(word))
Expand Down
Loading