fix(config): support MCO Home MH-S412 parameters properly #6623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just to be sure - do you have this exact device and can confirm the parameters? |
|
Absolutely! I've confirmed this particular device works correctly with the proposed parameters in this PR. I have the device physically and tested the changes locally. As a side note, I previously used this device with Jeedom and noticed a regression in behavior after switching to ZWaveJS. This prompted me to investigate and submit this PR. |
AlCalzone
approved these changes
Jul 10, 2024
AlCalzone
added a commit
that referenced
this pull request
Jul 11, 2024
### Breaking changes · [Migration guide](https://zwave-js.github.io/node-zwave-js/#/getting-started/migrating-to-v13) * Align Meter CC Reset v6 with specifications, add mocks, add API for report commands (#6921) * Convert all Z-Wave specific configs except devices and manufacturers into code, move from ConfigManager methods to utility functions (#6925, #6929) * Remove `ZWaveApplicationHost` dependency from `CommandClass.toLogEntry()` (#6927) * Removed some deprecated things (#6928) * Replace `Controller.isAssociationAllowed` with `Controller.checkAssociation` (#6935) * Fixed health checks for ZWLR nodes, throw when requesting neighbors (#6939) * The repo now uses Yarn 4 and Corepack to manage its dependencies (#6949) * "Master Code" was renamed to "Admin Code" (#6995) ### Config file changes * Update Zooz ZEN30 to latest revisions (#6630) * Support MCO Home MH-S412 parameters properly (#6623) * Add Ring Flood Freeze Sensor (#6970) * Override user code count for Yale ZW2 locks to expose admin code (#6528) * Add GDZW7-ECO Ecolink 700 Series Garage Door Controller (#6572) * Correct label for Remote 3-Way Switch parameter on Zooz ZEN32 (#6871) * Add UltraPro 700 Series Z-Wave In-Wall Smart Dimmer (#6904) * Add Yale Assure 2 Biometric Deadbolt locks (#6972) * Add iDevices In-Wall Smart Dimmer (#5521) * Support Comet parameters properly (#6583) * Update label of Nortek GD00Z-6, -7, -8 (#6991) * Disable Supervision for Zooz ZSE11 (#6990) * Clarify parameters and units for Everspring AN158 (#6364) * Force-add support for Multilevel Switch CC to FGRM-222, remove Binary Switch CC (#6986) ### Changes under the hood * Upgrade to TypeScript 5.5 (#6919) * The root `tsconfig.json` is now set up in "solution-style", which should improve the goto references functionality. In addition, linting, testing and running locally no longer requires all modules to be compiled first. (#6748) * Fixed some minor issues found by code scanning (#6992) * Fixed an issue where `yarn codefind` was loading no source files (#6993) * Fixed an issue where `import(...)` types with absolute paths could appear in in CC docs (#6996)
AlCalzone
added a commit
that referenced
this pull request
Jul 15, 2024
### Breaking changes · [Migration guide](https://zwave-js.github.io/node-zwave-js/#/getting-started/migrating-to-v13) * Align Meter CC Reset v6 with specifications, add mocks, add API for report commands (#6921) * Convert all Z-Wave specific configs except devices and manufacturers into code, move from ConfigManager methods to utility functions (#6925, #6929) * Remove `ZWaveApplicationHost` dependency from `CommandClass.toLogEntry()` (#6927) * Removed some deprecated things (#6928) * Replace `Controller.isAssociationAllowed` with `Controller.checkAssociation` (#6935) * Fixed health checks for ZWLR nodes, throw when requesting neighbors (#6939) * The repo now uses Yarn 4 and Corepack to manage its dependencies (#6949) * "Master Code" was renamed to "Admin Code" (#6995) ### Features * `mock-server` now supports communication with endpoints (#7005) ### Config file changes * Update Zooz ZEN30 to latest revisions (#6630) * Support MCO Home MH-S412 parameters properly (#6623) * Add Ring Flood Freeze Sensor (#6970) * Override user code count for Yale ZW2 locks to expose admin code (#6528) * Add GDZW7-ECO Ecolink 700 Series Garage Door Controller (#6572) * Correct label for Remote 3-Way Switch parameter on Zooz ZEN32 (#6871) * Add UltraPro 700 Series Z-Wave In-Wall Smart Dimmer (#6904) * Add Yale Assure 2 Biometric Deadbolt locks (#6972) * Add iDevices In-Wall Smart Dimmer (#5521) * Support Comet parameters properly (#6583) * Update label of Nortek GD00Z-6, -7, -8 (#6991) * Disable Supervision for Zooz ZSE11 (#6990) * Clarify parameters and units for Everspring AN158 (#6364) * Force-add support for Multilevel Switch CC to FGRM-222, remove Binary Switch CC (#6986) ### Changes under the hood * Upgrade to TypeScript 5.5 (#6919) * The root `tsconfig.json` is now set up in "solution-style", which should improve the goto references functionality. In addition, linting, testing and running locally no longer requires all modules to be compiled first. (#6748) * Fixed some minor issues found by code scanning (#6992) * Fixed an issue where `yarn codefind` was loading no source files (#6993) * Fixed an issue where `import(...)` types with absolute paths could appear in in CC docs (#6996)
AlCalzone
added a commit
that referenced
this pull request
Jul 15, 2024
### Breaking changes · [Migration guide](https://zwave-js.github.io/node-zwave-js/#/getting-started/migrating-to-v13) * Align Meter CC Reset v6 with specifications, add mocks, add API for report commands (#6921) * Convert all Z-Wave specific configs except devices and manufacturers into code, move from ConfigManager methods to utility functions (#6925, #6929) * Remove `ZWaveApplicationHost` dependency from `CommandClass.toLogEntry()` (#6927) * Removed some deprecated things (#6928) * Replace `Controller.isAssociationAllowed` with `Controller.checkAssociation` (#6935) * Fixed health checks for ZWLR nodes, throw when requesting neighbors (#6939) * The repo now uses Yarn 4 and Corepack to manage its dependencies (#6949) * "Master Code" was renamed to "Admin Code" (#6995) ### Features * `mock-server` now supports communication with endpoints (#7005) ### Config file changes * Update Zooz ZEN30 to latest revisions (#6630) * Support MCO Home MH-S412 parameters properly (#6623) * Add Ring Flood Freeze Sensor (#6970) * Override user code count for Yale ZW2 locks to expose admin code (#6528) * Add GDZW7-ECO Ecolink 700 Series Garage Door Controller (#6572) * Correct label for Remote 3-Way Switch parameter on Zooz ZEN32 (#6871) * Add UltraPro 700 Series Z-Wave In-Wall Smart Dimmer (#6904) * Add Yale Assure 2 Biometric Deadbolt locks (#6972) * Add iDevices In-Wall Smart Dimmer (#5521) * Support Comet parameters properly (#6583) * Update label of Nortek GD00Z-6, -7, -8 (#6991) * Disable Supervision for Zooz ZSE11 (#6990) * Clarify parameters and units for Everspring AN158 (#6364) * Force-add support for Multilevel Switch CC to FGRM-222, remove Binary Switch CC (#6986) ### Changes under the hood * Upgrade to TypeScript 5.5 (#6919) * The root `tsconfig.json` is now set up in "solution-style", which should improve the goto references functionality. In addition, linting, testing and running locally no longer requires all modules to be compiled first. (#6748) * Fixed some minor issues found by code scanning (#6992) * Fixed an issue where `yarn codefind` was loading no source files (#6993) * Fixed an issue where `import(...)` types with absolute paths could appear in in CC docs (#6996)
AlCalzone
added a commit
that referenced
this pull request
Jul 16, 2024
### Breaking changes · [Migration guide](https://zwave-js.github.io/node-zwave-js/#/getting-started/migrating-to-v13) * Align Meter CC Reset v6 with specifications, add mocks, add API for report commands (#6921) * Convert all Z-Wave specific configs except devices and manufacturers into code, move from ConfigManager methods to utility functions (#6925, #6929) * Remove `ZWaveApplicationHost` dependency from `CommandClass.toLogEntry()` (#6927) * Removed some deprecated things (#6928) * Replace `Controller.isAssociationAllowed` with `Controller.checkAssociation` (#6935) * Fixed health checks for ZWLR nodes, throw when requesting neighbors (#6939) * The repo now uses Yarn 4 and Corepack to manage its dependencies (#6949) * "Master Code" was renamed to "Admin Code" (#6995) ### Features * `mock-server` now supports communication with endpoints (#7005) ### Config file changes * Update Zooz ZEN30 to latest revisions (#6630) * Support MCO Home MH-S412 parameters properly (#6623) * Add Ring Flood Freeze Sensor (#6970) * Override user code count for Yale ZW2 locks to expose admin code (#6528) * Add GDZW7-ECO Ecolink 700 Series Garage Door Controller (#6572) * Correct label for Remote 3-Way Switch parameter on Zooz ZEN32 (#6871) * Add UltraPro 700 Series Z-Wave In-Wall Smart Dimmer (#6904) * Add Yale Assure 2 Biometric Deadbolt locks (#6972) * Add iDevices In-Wall Smart Dimmer (#5521) * Support Comet parameters properly (#6583) * Update label of Nortek GD00Z-6, -7, -8 (#6991) * Disable Supervision for Zooz ZSE11 (#6990) * Clarify parameters and units for Everspring AN158 (#6364) * Force-add support for Multilevel Switch CC to FGRM-222, remove Binary Switch CC (#6986) ### Changes under the hood * Upgrade to TypeScript 5.5 (#6919) * The root `tsconfig.json` is now set up in "solution-style", which should improve the goto references functionality. In addition, linting, testing and running locally no longer requires all modules to be compiled first. (#6748) * Fixed some minor issues found by code scanning (#6992) * Fixed an issue where `yarn codefind` was loading no source files (#6993) * Fixed an issue where `import(...)` types with absolute paths could appear in in CC docs (#6996)
AlCalzone
added a commit
that referenced
this pull request
Jul 17, 2024
### Application compatibility Home Assistant users who manage `zwave-js-server` themselves, **must** install the following upgrades before upgrading to this driver version: * Home Assistant **TBD** or higher * `zwave-js-server` **1.37.0** ### Breaking changes · [Migration guide](https://zwave-js.github.io/node-zwave-js/#/getting-started/migrating-to-v13) * Align Meter CC Reset v6 with specifications, add mocks, add API for report commands (#6921) * Convert all Z-Wave specific configs except devices and manufacturers into code, move from ConfigManager methods to utility functions (#6925, #6929, #7023) * Remove `ZWaveApplicationHost` dependency from `CommandClass.toLogEntry()` (#6927) * Removed some deprecated things (#6928) * Replace `Controller.isAssociationAllowed` with `Controller.checkAssociation` (#6935) * Fixed health checks for ZWLR nodes, throw when requesting neighbors (#6939) * The repo now uses Yarn 4 and Corepack to manage its dependencies (#6949) * "Master Code" was renamed to "Admin Code" (#6995) ### Features * `mock-server` now supports communication with endpoints (#7005) ### Bugfixes * Reset aborted flags when starting link reliability or route health check (#7022) ### Config file changes * Update Zooz ZEN30 to latest revisions (#6630) * Support MCO Home MH-S412 parameters properly (#6623) * Add Ring Flood Freeze Sensor (#6970) * Override user code count for Yale ZW2 locks to expose admin code (#6528) * Add GDZW7-ECO Ecolink 700 Series Garage Door Controller (#6572) * Correct label for Remote 3-Way Switch parameter on Zooz ZEN32 (#6871) * Add UltraPro 700 Series Z-Wave In-Wall Smart Dimmer (#6904) * Add Yale Assure 2 Biometric Deadbolt locks (#6972) * Add iDevices In-Wall Smart Dimmer (#5521) * Support Comet parameters properly (#6583) * Update label of Nortek GD00Z-6, -7, -8 (#6991) * Disable Supervision for Zooz ZSE11 (#6990) * Clarify parameters and units for Everspring AN158 (#6364) * Force-add support for Multilevel Switch CC to FGRM-222, remove Binary Switch CC (#6986) * Add ZVIDAR Z-PI 800 Series PI Module (#7018) ### Changes under the hood * Upgrade to TypeScript 5.5 (#6919) * The root `tsconfig.json` is now set up in "solution-style", which should improve the goto references functionality. In addition, linting, testing and running locally no longer requires all modules to be compiled first. (#6748) * Fixed some minor issues found by code scanning (#6992) * Fixed an issue where `yarn codefind` was loading no source files (#6993) * Fixed an issue where `import(...)` types with absolute paths could appear in in CC docs (#6996)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
It was not merged recently nor has a pending PR
Device
Mco Home Technology Co. LTD MH-S412
Manufacturer ID
0x015f
Product Type
0x4121
Product ID
0x5102
Is the device listed on the Z-Wave Alliance website?
No
Do you have a manual?
Yes
http://mcohome.com/index.php?c=Front/DownDetail&a=downloadFujian&name=MH-S412&path=L2NvbWRhdGEvOTUzMDEvcHJvZHVjdGZ1amlhbi8yMDIxMDIwMzE3Mjc0NjYwMWE2YzkyYjIxMTQucGRm