Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vsce version to latest 2.x and use newer vscode scoped package #150

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

awharn
Copy link
Member

@awharn awharn commented Sep 23, 2024

What It Does

Update vsce dependency to use @vscode/vsce and use latest 2.x version

How to Test

Review Checklist
I certify that I have:

Additional Comments

Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.17%. Comparing base (fba006e) to head (aa261ca).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #150   +/-   ##
=======================================
  Coverage   93.17%   93.17%           
=======================================
  Files          73       73           
  Lines         718      718           
  Branches       54       55    +1     
=======================================
  Hits          669      669           
  Misses         49       49           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Andrew!

Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @awharn!

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating! 🙏🏽
BTW, no new version required

@awharn awharn merged commit 67c86dc into main Sep 23, 2024
17 checks passed
@awharn awharn deleted the update-vsce branch September 23, 2024 15:42
@awharn awharn added the release-current Indicates that there is no new functionality being delivered label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-current Indicates that there is no new functionality being delivered
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

5 participants