Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflow permissions (v3) #142

Merged
merged 7 commits into from
Sep 11, 2024
Merged

Conversation

awharn
Copy link
Member

@awharn awharn commented Sep 9, 2024

What It Does

Update dependencies for technical currency
Updates workflow permissions for v3
Update tests to support changes made in v3.

  • Profiles are no longer supported, passing values in as arguments
  • Port (a number) is no longer a string, fix type mismatch

How to Test

Review Checklist
I certify that I have:

Additional Comments

Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
@awharn awharn self-assigned this Sep 9, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.17%. Comparing base (6bb2fb7) to head (379dc50).
Report is 1 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #142   +/-   ##
=======================================
  Coverage   93.17%   93.17%           
=======================================
  Files          73       73           
  Lines         718      718           
  Branches       55       54    -1     
=======================================
  Hits          669      669           
  Misses         49       49           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

@zFernand0 zFernand0 merged commit a08a64a into next Sep 11, 2024
13 checks passed
@zFernand0 zFernand0 deleted the update-workflow-permissions-v3 branch September 11, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

5 participants