Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icons): Display icons for all resources #114

Merged
merged 5 commits into from
Mar 1, 2024
Merged

fix(icons): Display icons for all resources #114

merged 5 commits into from
Mar 1, 2024

Conversation

zFernand0
Copy link
Member

What It Does

How to Test

  1. npm i
  2. npm run build
  3. Run the debugger and you should see icons now 😋

Review Checklist
I certify that I have:

Additional Comments

- fixes #112

Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.28%. Comparing base (7e44122) to head (8839488).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #114   +/-   ##
=======================================
  Coverage   93.28%   93.28%           
=======================================
  Files          74       74           
  Lines         760      760           
  Branches       93       94    +1     
=======================================
  Hits          709      709           
  Misses         51       51           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...I guess you could say this PR is iconic 🥁

LGTM, thanks @zFernand0!

Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
@zFernand0
Copy link
Member Author

this also fixes #111
more details in this comment:

@zFernand0 zFernand0 linked an issue Feb 28, 2024 that may be closed by this pull request
.vscode/settings.json Outdated Show resolved Hide resolved
Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @zFernand0!

Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
Copy link
Contributor

@rudyflores rudyflores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zFernand0 sorry for the late review!

@zFernand0 zFernand0 merged commit 48cc278 into main Mar 1, 2024
8 checks passed
@zFernand0 zFernand0 deleted the fix/icons branch March 1, 2024 18:00
@zFernand0 zFernand0 added the release-patch Indicates a patch to existing code has been applied label Mar 2, 2024
Copy link

github-actions bot commented Mar 2, 2024

Release succeeded for the main branch. 🎉

The following packages have been published:

Powered by Octorelease 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-patch Indicates a patch to existing code has been applied released
Projects
Status: Closed
5 participants