Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Readme and fix lint issues #109

Merged
merged 4 commits into from
Feb 26, 2024
Merged

Update Readme and fix lint issues #109

merged 4 commits into from
Feb 26, 2024

Conversation

zFernand0
Copy link
Member

@zFernand0 zFernand0 commented Feb 21, 2024

What It Does

  • Document the exit code in the CLI README file
  • Address all lint issues in the SDK and the CLI
  • Replaced any deprecated items
  • Added deprecation (eslint plug-in)
  • Removed V1 profile read in favor of parms.arguments

How to Test

  • Build and run the plug-in, OR
  • Run system tests 😋

Review Checklist
I certify that I have:

Additional Comments

This should take care of the remaining V3 conformance work

@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.17%. Comparing base (595d1e1) to head (4966a81).
Report is 1 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next     #109      +/-   ##
==========================================
- Coverage   93.53%   93.17%   -0.37%     
==========================================
  Files          73       73              
  Lines         758      718      -40     
  Branches       94       54      -40     
==========================================
- Hits          709      669      -40     
  Misses         49       49              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@anaxceron anaxceron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fantastic!

packages/cli/README.md Outdated Show resolved Hide resolved
@zFernand0 zFernand0 changed the base branch from main to next February 22, 2024 14:55
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
@JTonda JTonda marked this pull request as draft February 22, 2024 16:07
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
@zFernand0 zFernand0 changed the title Update README.md Update Readme and fix lint issues Feb 22, 2024
@zFernand0 zFernand0 marked this pull request as ready for review February 22, 2024 21:59
@zFernand0
Copy link
Member Author

zFernand0 commented Feb 22, 2024

Windows builds fail due to a quoting problem in the "Update Dependencies" script

C:\Windows\system32\cmd.exe /D /S /C "C:\hostedtoolcache\windows\node\16.20.2\x64\npx.cmd -y -- syncpack@8 fix-mismatches --dev --prod --filter "@zowe/imperative|@zowe/zowe-explorer-api""

Update
"@zowe/imperative|@zowe/zowe-explorer-api"" this feels a bit strange 😋
Will investigate some more tomorrow though 😋


Thanks @t1m0thyj for the quick fix

@zFernand0
Copy link
Member Author

@anaxceron
I know there are a lot more changes this time around.
So I hope this link (below) makes it easy to review the README.md update

packages/cli/package.json Outdated Show resolved Hide resolved
Copy link

@anaxceron anaxceron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had one comment, otherwise, lookin' great!

packages/cli/CHANGELOG.md Show resolved Hide resolved
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @zFernand0!

Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @zFernand0! 😁

@traeok traeok merged commit 0f9d593 into next Feb 26, 2024
13 of 15 checks passed
@traeok traeok deleted the update-readme branch February 26, 2024 15:27
Copy link

Release succeeded for the next branch. 🎉

The following packages have been published:

Powered by Octorelease 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

6 participants