Escape urls, implement auto-prefixing and configurable link anchors #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cormacrelf
commented
Oct 14, 2021
Comment on lines
+7
to
+12
| result: >- | ||
| {\field{\*\fldinst{HYPERLINK "https://google.com/?%E2%80%9D%C3%97%7B%7D%5C%7B%5Chello%7D"}}{\fldrslt https://google.com/?%E2%80%9D%C3%97\{\}\\\{\\hello\}}} | ||
|
|
||
| input: | ||
| - id: a | ||
| url: 'https://google.com/?”×{}\{\hello}' |
There was a problem hiding this comment.
Includes a test on hard mode 🦆
cormacrelf
commented
Oct 14, 2021
Comment on lines
283
to
+288
| let driverResult = Driver.new({ | ||
| style: "<style version=\"1.0\" class=\"note\" ... > ... </style>", | ||
| format: "html", // optional, html is the default | ||
| formatOptions: { // optional | ||
| linkAnchors: true, // optional, default true | ||
| }, |
There was a problem hiding this comment.
This is how to turn it off via wasm api, for csl 1.0.2 compliance ✅
cormacrelf
commented
Oct 15, 2021
cormacrelf
force-pushed
the
fix-url-escaping
branch
from
64601f5
to
9fdebbb
Compare
cormacrelf
added
A-core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #123, fixes #116, fixes #115