Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pure python build #94

Merged
merged 10 commits into from
Aug 2, 2024
Merged

fix: pure python build #94

merged 10 commits into from
Aug 2, 2024

Conversation

tseaver
Copy link
Member

@tseaver tseaver commented Jun 27, 2024

Note that wheels built with PURE_PYTHON=1 set will be 'py3-none-any` wheels. I'm not sure whether this PR should update the GHA workflow to cause such a wheel to be built.

We can't properly test the 'PURE_PYTHON=1' case if the C extensions are
built in-place in the package.
Fix a test which relied on the extension being importable due to
'usedevlop = true' in 'tox.ini'.

Closes #93.
@dataflake
Copy link
Member

Note that wheels built with PURE_PYTHON=1 set will be 'py3-none-any` wheels. I'm not sure whether this PR should update the GHA workflow to cause such a wheel to be built.

The wheel is already built - for pypy. The item "zodbpickle-Linux-pypy-3.10.whl" in the artifacts list for the GHA is a zip file that expands to "zodbpickle-4.1.dev0-py3-none-any.whl" when unzipped. However, the step "Publish package to PyPI (Non-Linux)" makes an explicit exception that won't upload the wheel for pypy:

https://github.com/zopefoundation/meta/blob/2335304960c651a5974ade383beb0b20d4f4c471/config/c-code/tests.yml.j2#L217-L232

Removing that exception would upload the py3-none-any wheel. I'm not sure how valuable that is or if it would affect other architectures if the buggy buildout/setuptools chain disregards suitable binary wheels and chooses the py3-none-any in favor of the tarball?

@tseaver
Copy link
Member Author

tseaver commented Aug 2, 2024

@dataflake I'm unclear why we even build *-pypy-3.10.whl distributions for the c-code family. I don't believ we are providing something special under the covers (e.g, using cpyext, as in this blog entry or cffi or Hpy), different than the sdist or the *-none-any.whl would provide.

Copy link
Member

@icemac icemac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from reading the diff.

@tseaver tseaver merged commit c7a9678 into master Aug 2, 2024
54 checks passed
@tseaver tseaver deleted the tseaver-93-fix_pure_python_build branch August 2, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants