Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sector Nord AG: Fixed all missing german translations. #457

Closed
wants to merge 1 commit into from

Conversation

paulfolkers
Copy link

Proposed change

In Znuny 7 there are many german translations missing, which will be available now.

1 - 🐞 bug 🐞

Additional information

Checklist

  • The code change is tested and works locally.(❗)
  • There is no commented out code in this PR.(❕)
  • You improved or added new unit tests.(❕)
  • Local ZnunyCodePolicy passed.(❕)
  • Local UnitTests / Selenium passed.(❕)
  • GitHub workflow CI (UnitTests / Selenium) passed.(❗)

Units tests and code policy are not applicable to this.

@paulfolkers paulfolkers changed the title Fixed all missing german translations Sector Nord: Fixed all missing german translations Jul 3, 2023
@paulfolkers paulfolkers changed the title Sector Nord: Fixed all missing german translations Sector Nord AG: Fixed all missing german translations Jul 3, 2023
@dignin
Copy link

dignin commented Jul 4, 2023

Hi @paulfolkers , thanks for helping out here. If you have translation fixes in the future, please translate using the Weblate platform. https://translations.znuny.org/projects/znuny/znuny/de/ This will save you and us time in the long run. I've passed this on and @dennykorsukewitz will contact you if needed.

@paulfolkers
Copy link
Author

Hi @paulfolkers , thanks for helping out here. If you have translation fixes in the future, please translate using the Weblate platform. https://translations.znuny.org/projects/znuny/znuny/de/ This will save you and us time in the long run. I've passed this on and @dennykorsukewitz will contact you if needed.

Hi Shawn, didn't know about that, thank you.
Are you able to merge it or should I fill the missing translations at the Weblate platform?

@dennykorsukewitz dennykorsukewitz self-assigned this Jul 4, 2023
@dennykorsukewitz dennykorsukewitz added this to the rel-7_0_8 milestone Jul 4, 2023
@dennykorsukewitz
Copy link
Member

Hi @paulfolkers ,

All files under Kernel/Language/* are automatically generated from the i18n/Znuny/Znuny.*.po via
bin/otrs.Console.pl Dev::Tools::TranslationsUpdate.
I can only merge the PR if you also edit the Znuny.de.po.

But as Shawn said, organizationally we want to separate the translations from the code here.

Anyway, thank you for your PR.
In this one case you may decide whether to extend the PR or use Weblate.
I am OK with both.

Regards 🚀

@dennykorsukewitz dennykorsukewitz added the 3 - wait for contributor Contributor, it's your turn. label Jul 4, 2023
@dennykorsukewitz dennykorsukewitz changed the title Sector Nord AG: Fixed all missing german translations Sector Nord AG: Fixed all missing german translations. Jul 4, 2023
@paulfolkers
Copy link
Author

Hi @dennykorsukewitz, I placed all translation suggestions in Weblate.
I did not create an account for that, we'd be happy if you could just mention Sector Nord AG in your changelog then. ;-)

I will close this PR for now, since this code merge is not necessary now.

@paulfolkers paulfolkers closed this Jul 4, 2023
@dennykorsukewitz dennykorsukewitz removed the 3 - wait for contributor Contributor, it's your turn. label Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants