Add error handling for FTP TLS handshake #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks like it will prevent attempting to grab banner if the TLS handshake fails. I believe that this is the right thing to do since it's a TLS wrapped FTP session not running TLS after FTP has started. @codyprime can you confirm that this makes sense? |
zakird
approved these changes
Jun 6, 2021
codyprime
approved these changes
Jun 8, 2021
Yeah, I also believe this is the correct thing to do, since in this path TLS was requested for this scan. We should error out if we cannot establish a TLS connection. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests adds a check in modules/ftp/scanner.go for an error upon completing a TLS handshake.