ftp: Add support for implicit TLS #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codyprime
force-pushed
the
jcody/ftp-implicit-tls-opt
branch
from
ca1f368
to
4c3e52c
Compare
bwireman
reviewed
May 27, 2020
modules/ftp/scanner.go
Outdated
| FTPAuthTLS bool `long:"authtls" description:"Collect FTPS certificates in addition to FTP banners"` | ||
| Verbose bool `long:"verbose" description:"More verbose logging, include debug fields in the scan results"` | ||
| FTPAuthTLS bool `long:"authtls" description:"Collect FTPS certificates in addition to FTP banners"` | ||
| ImplicitTLS bool `long:"implicit-tls" description:"Attempt to connect via a TLS wrapped connection first"` |
There was a problem hiding this comment.
Attempt to connect via a TLS wrapped connection first implies it will attempt plain text next, which doesn't appear to be the case
bwireman
approved these changes
May 27, 2020
codyprime
force-pushed
the
jcody/ftp-implicit-tls-opt
branch
2 times, most recently
from
4ae6898
to
84a8b32
Compare
The command line option `--implicit-tls` will attempt connecting via TLS before intiating the FTP handshake.
codyprime
force-pushed
the
jcody/ftp-implicit-tls-opt
branch
from
84a8b32
to
f6fbfc5
Compare
|
rebased to master |
bwireman
approved these changes
May 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command line option
--implicit-tlswill attempt connecting viaTLS before intiating the FTP handshake.
How to Test
You need to find a server that is using TLS around FTP (but not auth-tls or auth-ssl), and run:
echo ip_address | zgrab2 ftp --port 990 --implicit-tlsNotes & Caveats
Issue Tracking