Deferred Montgomery reductions #20
Open
+324
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebfull
commented
Nov 22, 2019
| /// Negates an element of magnitude 1 by subtracting it from a multiple of | ||
| /// the prime that is larger than this element could be (p^2), increasing | ||
| /// the magnitude by 1. | ||
| pub const fn negate(&self) -> FpWide { |
There was a problem hiding this comment.
This should be called negate_u1. (I would use a generic, but it's not stable in Rust yet for const functions...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3.
There are some places in the curve arithmetic where this could help also, I haven't exhaustively looked yet.