Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump REVM #108

Closed
gakonst opened this issue Dec 15, 2022 · 5 comments · Fixed by #115
Closed

Bump REVM #108

gakonst opened this issue Dec 15, 2022 · 5 comments · Fixed by #115
Assignees
@ziyadedher

Comments

@gakonst
Copy link

gakonst commented Dec 15, 2022

Revm got a bunch of nice performance updates lately in bluealloy/revm#283, would be nice to update the benches
@gakonst
Copy link
Author

gakonst commented Dec 17, 2022

@ziyadedher lmk if you are planning on tackling this, else happy to do it myself!

@ziyadedher
Copy link
Owner

Thanks for the bump! Been feeling a bit under the weather last few days so this slipped through the cracks. Lemme knock this one out right now.

@ziyadedher ziyadedher self-assigned this Dec 17, 2022
@ziyadedher
Copy link
Owner

Seeing ~10-12% speedups 😎 which seems consistent with @bluealloy's results on snailtracer.

PR coming in a few minutes once the rest of the benches finish running (so it picks up updates to other packages).

@gakonst
Copy link
Author

gakonst commented Dec 17, 2022 •
edited
Loading

Sick. Amazing - thank you! Worth also updating pyrevm, I'll give that a pass unless you want to.

@ziyadedher ziyadedher mentioned this issue Dec 17, 2022
Merged
@ziyadedher
Copy link
Owner

#115

Worth also updating pyrevm, I'll give that a pass unless you want to.

Might be worth waiting until a release of revm comes out that includes the perf boost. I just pinned to main in the bench here.

ziyadedher added a commit that referenced this issue Dec 17, 2022
@ziyadedher
Bump revm version and make it start working again (#115)
fcbce9c 
Closes #108 

Note that Akula isn't included here cuz I can't manage to get their repo
to bench anymore. I might try to fix it in a bit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ziyadedher ziyadedher

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump revm version and make it start working again ziyadedher/evm-bench
2 participants
@ziyadedher @gakonst