Scala native support #1010
Merged
Scala native support #1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DamianReeves
reviewed
Sep 4, 2023
| assertTrue(OverridesAlsoWork("", 0).toJson == overrides) | ||
| }, | ||
| test("key transformation - except native") { | ||
| // Problem in scala-native seems to be with implementation of package scala.scalanative.regex.Parser, in particular method `parsePerlFlags`. |
There was a problem hiding this comment.
Any chance this was reported up to the scala-native project as a problem, or is that a TODO?
There was a problem hiding this comment.
Never mind, I see you did in the attached issues above.
DamianReeves
approved these changes
Sep 4, 2023
There was a problem hiding this comment.
More awesome work. Thanks for this.
@jdegoes / @adamgfraser this looks good to me.
adamgfraser
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/claim #985
@DamianReeves Hi again! Support for scala native. Everything is supported although regex has a strange behaviour in test "key transformation". This is due to the implementation of
java.util.regexin scala-native.See:
scala-native/scala-native#620
scala-native/scala-native#3460