Graceful message and exit for wrong value of phase #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonalgoyal
reviewed
Dec 22, 2021
sonalgoyal
requested changes
Dec 22, 2021
| @@ -21,6 +22,7 @@ | |||
| private ClientOptions options; | |||
|
|
|||
| public static final Log LOG = LogFactory.getLog(Client.class); | |||
| public static final int EXIT_STATUS_ILLEGAL_CMD = 127; | |||
| @@ -131,6 +133,11 @@ public static void main(String... args) { | |||
| System.exit(0); | |||
| } | |||
| String phase = options.get(ClientOptions.PHASE).value.trim(); | |||
| if (ZinggOptions.getByValue(phase) == null) { | |||
There was a problem hiding this comment.
throw exception with right message
There was a problem hiding this comment.
This is the message as part of thrown exception
Apologies for this message. Zingg has encountered an error. 'findTrainingDat' is not a valid phase. Valid phases are: train|match|trainMatch|findTrainingData|label|link
| int exitStatusExpected = 127; // error code for an illegal command e.g. typo | ||
| try { | ||
| String zinggInvalidPhaseCmd = "scripts/zingg.sh --phase findTrainingDat --conf examples/febrl/config.json"; | ||
| Process p = Runtime.getRuntime().exec(zinggInvalidPhaseCmd, null, new File(System.getenv("ZINGG_HOME"))); |
There was a problem hiding this comment.
can we just call the client with the args instead of execing a new process here? and simply assert that an exception happens ?
There was a problem hiding this comment.
testcases have been updated to test the new functionality that is refactored into ZinggOptions.verifyPhase(phase).
ZinggOptions has been chosen for it is the central place to maintain zingg options or phases.
sonalgoyal
approved these changes
Dec 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#81 wrong value of phase shows stack trace - should be handled gracefully