issue #558 linker not working #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
sonalgoyal
reviewed
Apr 25, 2023
| @@ -130,7 +130,12 @@ public ZFrame<Dataset<Row>, Row, Column> dropDuplicates(String c, String... d) { | |||
| public ZFrame<Dataset<Row>, Row, Column> drop(String c) { | |||
There was a problem hiding this comment.
invoke drop(Column) here instead of going to spark api directly. then code is in one place only
There was a problem hiding this comment.
i don't think that would helps as:
- To invoke drop(Column) we would still use functions.col or df.col to get column object from column name , so dependency on spark is not reduced.
- Currently spark frame works as a adapter over data set where we delegate most of the methods to the data set object. This is exactly what we are doing with both drop methods. Now introducing logic in one of the drop methods instead of simple delegation does not make much sense
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linker issue fixed