Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getUnmarkedRecords() - updated to the version with correct functionality and fixed its name #372

Merged
merged 2 commits into from
Jul 5, 2022
Merged

getUnmarkedRecords() - updated to the version with correct functionality and fixed its name #372

merged 2 commits into from
Jul 5, 2022

Conversation

navinrathore
Copy link
Contributor

  • Renamed getUnMarkedRecords() to getUnmarkedRecords()
  • Real unmarked records returned - updated function from Labeller class

@navinrathore
Copy link
Contributor Author

Few points for attention:

  • getMarkedRecords() called twice in labeller. reading the marked record twice from file.
  • assessModel prints following
INFO:zingg.assessModel:No. of Records Marked   : 76
INFO:zingg.assessModel:No. of Records UnMarked : 40
INFO:zingg.assessModel:No. of Matches          : 14
INFO:zingg.assessModel:No. of Non-Matches      : 24
INFO:zingg.assessModel:No. of Not Sure         : 0

marked and unmarked records are absolute number of records whereas remaining three are pairs (returned by called functions)
a) Should marked and unmarked records too be in pairs?
b) should the word "(pairs)" be used in statements?

@navinrathore navinrathore mentioned this pull request Jun 30, 2022
Closed
@navinrathore
Copy link
Contributor Author

sonalgoyal
sonalgoyal requested changes Jul 4, 2022
View reviewed changes
core/src/main/java/zingg/Labeller.java Outdated
@@ -33,6 +33,7 @@ public Labeller() {
public void execute() throws ZinggClientException {
try {
LOG.info("Reading inputs for labelling phase ...");
initLabellerStat();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this method and simply call getMarkedRecordStat. Move null check into that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

core/src/main/java/zingg/Labeller.java Outdated
}
} catch (ZinggClientException e) {
LOG.warn("No unmarked record for labelling");
public void initLabellerStat() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rm

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

python/phases/assessModel.py Outdated
@@ -19,7 +19,7 @@ def main():
client.initAndExecute()

pMarkedDF = client.getPandasDfFromDs(client.getMarkedRecords())
pUnMarkedDF = client.getPandasDfFromDs(client.getUnMarkedRecords())
pUnMarkedDF = client.getPandasDfFromDs(client.getUnmarkedRecords())

total_marked = pMarkedDF.shape[0]
total_unmarked = pUnMarkedDF.shape[0]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed the variable

@sonalgoyal sonalgoyal merged commit c14a59b into zinggAI:main Jul 5, 2022
@navinrathore navinrathore deleted the UnmarkedRecordsReorg branch July 28, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonalgoyal sonalgoyal sonalgoyal requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@navinrathore @sonalgoyal