Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Null Pointer check in "Range" hash functions #350

Merged
merged 3 commits into from
Jun 21, 2022
Merged

Null Pointer check in "Range" hash functions #350

merged 3 commits into from
Jun 21, 2022

Conversation

navinrathore
Copy link
Contributor

  • Handled 'Null' input value in Range set of hash functions. Added testcases also for same.
  • All other functions have the null chech. Test cases were also present.
  • List of new hash functions recently added
    LessThanZeroInt,LessThanZeroDbl,RangeDbl,RangeInt,,TruncateDouble,TrimLastDigitsInt,TrimLastDigitsDbl

@navinrathore navinrathore changed the title Test new models Null Pointer check in "Range" hash functions Jun 21, 2022
@navinrathore
Copy link
Contributor Author

Ref: Null Pointer exception occures when "DoubleType" column has string data #349

sonalgoyal
sonalgoyal requested changes Jun 21, 2022
View reviewed changes
Copy link
Member

@sonalgoyal sonalgoyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the apply method - will it work or will it fail? I dont see the changes there..?

@navinrathore
Copy link
Contributor Author

navinrathore commented Jun 21, 2022 •
edited
Loading

the apply method - will it work or will it fail? I dont see the changes there..?

For the issue, mentioned in this bug is solved by this fix. the fix is in consonance with other hash functions implementation.

The casting issue/message may have come in some other scenario/setup. The getAs() function is overloaded. It is supposed to return Double only. Aberrant scenario we have to find. We may raise a bug for that too!

@sonalgoyal sonalgoyal closed this Jun 21, 2022
@sonalgoyal sonalgoyal merged commit 4f3017a into zinggAI:main Jun 21, 2022
@navinrathore navinrathore deleted the TestNewModels branch July 10, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonalgoyal sonalgoyal sonalgoyal requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@navinrathore @sonalgoyal