Match type email #291
Match type email #291
Conversation
rename variable and fuction in TestPinCodeMatchTypeFunction class
|
|
||
|
|
||
|
|
||
| public class EmailMatchTypeFunction extends StringSimilarityFunction { |
There was a problem hiding this comment.
extend StringSimilarityDistanceFunction and use that
| public class TestEmailMatchTypeFunction { | ||
|
|
||
|
|
||
| @Test |
There was a problem hiding this comment.
please update test scores asserts accordingly. you can invoke the StringSimilarityDistanceFunction with the first part of email and check that you are getting what it returns
There was a problem hiding this comment.
I tried to do that. but, It is giving me this error: Cannot instantiate the type StringSimilarityDistanceFunction
should I leave that part by checking scores with EmailMatchTypeFunction ?
There was a problem hiding this comment.
ok, sorry I realized later it is an abstract class. Can you please extend AffineGapSimilarityFunction and use that in the tests as well?
There was a problem hiding this comment.
Ok, let me try that.
| String second = "xyz321@pqr.co"; | ||
| //first = first.split("@",0)[0]; | ||
| second = second.split("@",0)[0]; | ||
| assertEquals(1d, emailMatchFn.call(first, second)); |
There was a problem hiding this comment.
you need to verify here that the output from emailmatchfn is the same as the output from first part of emails sent to affinegap fn
| String second = "xyz321@pqr.co"; | ||
| first = first.split("@",0)[0]; | ||
| second = second.split("@",0)[0]; | ||
| assertEquals(1d, emailMatchFn.call(first, second)); |
There was a problem hiding this comment.
the function does the split here, you should not be splitting unless you want to send the split values to AffineGapSimilarityFunction
so validate that original first and second when passed to emailfn returns the same as first part of split string sent to affinegap similarity, ok?
issue #141