Documenter testcases #281
Documenter testcases #281
Conversation
| @BeforeEach | ||
| public void setUp(){ | ||
| try { | ||
| args = Arguments.createArgumentsFromJSON(getClass().getResource("/testConfig.json").getFile()); |
There was a problem hiding this comment.
please put configs in respective folders - tests/resources/documenter.config..json
| args = Arguments.createArgumentsFromJSON(getClass().getResource("/testConfig.json").getFile()); | ||
| } catch (Throwable e) { | ||
| e.printStackTrace(); | ||
| System.out.println("Unexpected exception received " + e.getMessage()); |
| Dataset<Row> data = PipeUtil.read(spark, false, false, args.getData()); | ||
| f.invoke(dataColDoc, data); | ||
|
|
||
| assertTrue(Files.exists(Paths.get(file1)), "Data col documentation add1.html is not generated"); |
There was a problem hiding this comment.
other than file path, is there a way to test other methods ?
There was a problem hiding this comment.
The template is verified at compile time itself. Generated html/csv file unittest may not help. We can add some way of verification, if we get issues in future.
https://stackoverflow.com/questions/3429218/unit-tests-for-html-output
| public void testProcessTemplateToMakeDocument() throws Throwable { | ||
|
|
||
| DocumenterBase base = new DocumenterBase(spark, args); | ||
| Method f = DocumenterBase.class.getDeclaredMethod("writeDocument", String.class, Map.class, String.class); |
There was a problem hiding this comment.
updated above.
| @@ -38,7 +37,7 @@ public void process() throws ZinggClientException { | |||
| modelColDoc.process(markedRecords); | |||
| } | |||
|
|
|||
| private void createModelDocument() throws ZinggClientException { | |||
| protected void createModelDocument() throws ZinggClientException { | |||
There was a problem hiding this comment.
we should separate the model from the view as in mvc architecture - one method to populate the data, and one to write the view. that will be far easier to test - you can send dataframes and verify that all that you want to display on the page is getting populated correctly in the map. the file writing is not so much of a concern as freemarker is taking care of it.
There was a problem hiding this comment.
Broken into two functions - populateTemplateData() and writeDataDocument()
Added 1 new test case.
| @@ -54,7 +54,7 @@ public void process() throws ZinggClientException { | |||
| } | |||
| } | |||
|
|
|||
| private void createDataDocument() throws ZinggClientException { | |||
| protected void createDataDocument() throws ZinggClientException { | |||
There was a problem hiding this comment.
if you break this method into one method that builds the map and second that uses the map and template to write it, you can test far more cases.
There was a problem hiding this comment.
Broken into two functions - populateTemplateData() and writeModelDocument();
Added 2 testcases.
|
moved template file into documenter resource folder |
Please provide inputs.