Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Executing maven compile at each commit #189

Merged
merged 3 commits into from
Apr 4, 2022

Conversation

edmondop
Copy link
Contributor

This is a beginning of CI implementation. It executes a maven package at every new commit, avoiding code that doesn't compile to be committed in main

@sonalgoyal
Copy link
Member

Thank for submitting this pr @edmondo1984. I see you have chosen jdk 11. Zingg is on jdk 8 to stay compatible with the Spark versions. Have you chosen jdk 11 intentionally?

@edmondop
Copy link
Contributor Author

edmondop commented Apr 3, 2022

Thank for submitting this pr @edmondo1984. I see you have chosen jdk 11. Zingg is on jdk 8 to stay compatible with the Spark versions. Have you chosen jdk 11 intentionally?

I should have fix it now

Copy link
Member

@sonalgoyal sonalgoyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay! first external code contribution to Zingg!

@sonalgoyal sonalgoyal merged commit 7a2b945 into zinggAI:main Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants