Extract Stop words #186
Merged
Extract Stop words #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
navinrathore
commented
Mar 23, 2022
navinrathore
commented
- Extracting stop words for each DONOT_USE field.
- stopWords are saved into csv files and html docs. The html docs have been linked in base documentation model.html
- Added new config param - stopWordsCutoff (default value = 0.1)
sonalgoyal
requested changes
Mar 23, 2022
| @@ -507,7 +508,7 @@ public String getZinggBaseModelDir() { | |||
|
|
|||
| @JsonIgnore | |||
| public String getZinggDocDir() { | |||
| return getZinggBaseModelDir(); | |||
| return zinggDir + "/" + modelId; | |||
There was a problem hiding this comment.
getZinggDocDir() was unused.
getZinggBaseModelDir() is models/<id>/model directory. it contains model detail.
The getZinggDocDir() seems corresponding to doc/documentation, therefore used after modification.
There was a problem hiding this comment.
thanks. so cant we then keep returning the getzinggBaseModelDir which is anyways what you are returning?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.