Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use environment variables in config files #60

Closed
jtinsky opened this issue Dec 3, 2021 · 4 comments
Closed

Use environment variables in config files #60

jtinsky opened this issue Dec 3, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@jtinsky
Copy link

jtinsky commented Dec 3, 2021

I'm considering using Snowflake as my primary data store and I'd like to have the connection information stored as environment variables instead of strings in the config file as shown in the Snowflake example config.

This was meant to be an enhancement/feature request so apologies if I submitted this incorrectly.

@sonalgoyal
Copy link
Member

Thanks @jtinsky for this feature request! Can I please understand a bit more about the need for saving the values in env ? Is that for security? I assume you only need the data and the output attributes of the config to come from the env?

@sonalgoyal sonalgoyal added the enhancement New feature or request label Dec 4, 2021
@sonalgoyal sonalgoyal self-assigned this Dec 4, 2021
@jtinsky
Copy link
Author

jtinsky commented Dec 5, 2021 via email

@sonalgoyal sonalgoyal added this to the 0.4 milestone Dec 6, 2021
@sonalgoyal
Copy link
Member

thanks @jtinsky , adding to zingg 0.4

@sonalgoyal
Copy link
Member

We can build it like this - template each variable jsonAttr:{{env.VAR_NAME}} and pick up the VAR_NAME from system environment of the driver program.

@sonalgoyal sonalgoyal assigned navinrathore and unassigned sonalgoyal Dec 9, 2021
navinrathore added a commit to navinrathore/zingg-1 that referenced this issue Dec 17, 2021
navinrathore added a commit to navinrathore/zingg-1 that referenced this issue Dec 17, 2021
navinrathore added a commit to navinrathore/zingg-1 that referenced this issue Dec 17, 2021
navinrathore added a commit to navinrathore/zingg-1 that referenced this issue Dec 20, 2021
navinrathore added a commit to navinrathore/zingg-1 that referenced this issue Dec 22, 2021
navinrathore added a commit to navinrathore/zingg-1 that referenced this issue Dec 23, 2021
sonalgoyal added a commit that referenced this issue Dec 28, 2021
Use environment variables in config files #60
gitbook-com bot pushed a commit that referenced this issue Aug 5, 2022
sonalgoyal added a commit that referenced this issue Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants